assert: fix rejects stack trace and operator#27047
Closed
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
This makes sure the stack trace is not removed due to a wrong stack start function being used. It also fixes the wrong operator caused by the same reason. This only applies in case an validation object was used to validate the rejection passed to `assert.reject()` as first argument.
Collaborator
nodejs-github-bot commented Apr 2, 2019
nodejs-github-bot added the assert 
MemberAuthor
BridgeAR commented Apr 3, 2019
@nodejs/assert PTAL |
MemberAuthor
BridgeAR commented Apr 5, 2019
@nodejs/util @nodejs/assert PTAL. This could use some reviews. |
Collaborator
nodejs-github-bot commented Apr 5, 2019
Trott approved these changes Apr 6, 2019
BridgeAR added the author ready Collaborator
nodejs-github-bot commented Apr 6, 2019
jasnell approved these changes Apr 6, 2019
Collaborator
CI: https://ci.nodejs.org/job/node-test-pull-request/22263/ ✅ (besides ARM) |
ZYSzys reviewed Apr 7, 2019
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Collaborator
nodejs-github-bot commented Apr 7, 2019
BridgeAR added a commit that referenced this pull request Apr 7, 2019
This makes sure the stack trace is not removed due to a wrong stack start function being used. It also fixes the wrong operator caused by the same reason. This only applies in case an validation object was used to validate the rejection passed to `assert.reject()` as first argument. PR-URL: #27047 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: James M Snell <[email protected]>
MemberAuthor
BridgeAR commented Apr 7, 2019
Landed in 75463a9 🎉 |
This was referenced Apr 23, 2019
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This makes sure the stack trace is not removed due to a wrong stack
start function being used. It also fixes the wrong operator caused
by the same reason. This only applies in case an validation object
was used to validate the rejection passed to
assert.reject()asfirst argument.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes