Skip to content

Conversation

@targos
Copy link
Member

Refs: v8/v8@7.4.288.13...7.4.288.17

@nodejs/v8-update

@nodejs-github-bot
Copy link
Collaborator

@nodejs-github-botnodejs-github-bot added the v8 engine Issues and PRs related to the V8 dependency. label Apr 3, 2019
@targostargos added dont-land-on-v10.x and removed v8 engine Issues and PRs related to the V8 dependency. labels Apr 3, 2019
@targos
Copy link
MemberAuthor

@nodejs-github-bot
Copy link
Collaborator

@nodejs-github-bot
Copy link
Collaborator

@targostargos changed the title deps: patch V8 to 7.4.288.17deps: patch V8 to 7.4.288.18Apr 5, 2019
@targos
Copy link
MemberAuthor

Updated to 7.4.288.18. I need at least one more approval.

@targos
Copy link
MemberAuthor

@nodejs-github-bot
Copy link
Collaborator

@nodejs-github-bot
Copy link
Collaborator

Copy link
Contributor

@refackrefack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

RSLGTM

targos added 2 commits April 5, 2019 08:45
Refs: v8/v8@7.4.288.13...7.4.288.17 PR-URL: nodejs#27066 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Refael Ackermann <[email protected]>
@refack
Copy link
Contributor

refack commented Apr 5, 2019

Landed in c86883c...135b79a31d51939d46b68eaea5249e28c7f67757

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@targos@nodejs-github-bot@refack@cjihrig