Uh oh!
There was an error while loading. Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork 34.3k
Fix typos in CLI docs, --entry-type error message#27067
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
targos approved these changes Apr 3, 2019
ZYSzys approved these changes Apr 3, 2019
BridgeAR approved these changes Apr 3, 2019
Collaborator
nodejs-github-bot commented Apr 3, 2019
devsnek approved these changes Apr 3, 2019
richardlau approved these changes Apr 3, 2019
vsemozhetbyt approved these changes Apr 3, 2019
Contributor
vsemozhetbyt commented Apr 3, 2019
Node.js Collaborators, please, add 👍 here if you approve fast-tracking. |
cjihrig approved these changes Apr 3, 2019
Contributor
vsemozhetbyt commented Apr 3, 2019
Landed in 5e98f87 |
vsemozhetbyt pushed a commit that referenced this pull request Apr 3, 2019
PR-URL: #27067 Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Yongsheng Zhang <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Gus Caplan <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Vse Mozhet Byt <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
BethGriggs pushed a commit that referenced this pull request Apr 4, 2019
PR-URL: #27067 Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Yongsheng Zhang <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Gus Caplan <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Vse Mozhet Byt <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
This was referenced Apr 23, 2019
This was referenced Jan 12, 2022
This was referenced Feb 9, 2022
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
Labels
author readyPRs that have at least one approval, no pending requests for changes, and a CI started. c++Issues and PRs that require attention from people who are familiar with C++. esmIssues and PRs related to the ECMAScript Modules implementation. fast-trackPRs that do not need to wait for 48 hours to land.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix some minor typos in docs and an error message.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes