stream: remove dead code#27125
Closed
stream: remove dead code #27125
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Remove unreachable code. `state.ended` is always set to true in this part of the code. The `else` clause can't be executed.
nodejs-github-bot added the stream 
addaleax approved these changes Apr 7, 2019
BridgeAR approved these changes Apr 7, 2019
ZYSzys approved these changes Apr 8, 2019
Collaborator
nodejs-github-bot commented Apr 8, 2019
cjihrig approved these changes Apr 8, 2019
ZYSzys added the author ready 
jasnell approved these changes Apr 8, 2019
tniessen approved these changes Apr 9, 2019
BridgeAR pushed a commit to BridgeAR/node that referenced this pull request Apr 10, 2019
Remove unreachable code. `state.ended` is always set to true in this part of the code. The `else` clause can't be executed. PR-URL: nodejs#27125 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Yongsheng Zhang <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Tobias Nießen <[email protected]>
Member
BridgeAR commented Apr 10, 2019
Landed in 1a67c99 🎉 |
This was referenced Apr 23, 2019
This was referenced Jan 12, 2022
This was referenced Jan 12, 2022
This was referenced Feb 9, 2022
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesRemoved unreachable code. In line
511,state.endedis set totrue. Soprocess.nextTick(emitReadable_, stream);can't be reached.