Uh oh!
There was an error while loading. Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork 34.3k
lib,src,doc: add --heapsnapshot-signal CLI flag#27133
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Uh oh!
There was an error while loading. Please reload this page.
Conversation
nodejs-github-bot commented Apr 8, 2019
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
jasnell left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM with @joyeecheung's comment addressed
richardlau commented Apr 8, 2019
Does this work on Windows? (I'm guessing not, at least based on the equivalent test in node/test/report/test-report-config.js Lines 63 to 87 in cc4e8e0
|
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
e89e9d6 to 2520bf7Comparenodejs-github-bot commented Apr 11, 2019
nodejs-github-bot commented Apr 12, 2019
nodejs-github-bot commented Apr 12, 2019 • edited by cjihrig
Loading Uh oh!
There was an error while loading. Please reload this page.
edited by cjihrig
Uh oh!
There was an error while loading. Please reload this page.
CI: https://ci.nodejs.org/job/node-test-pull-request/22395/ EDIT(cjihrig): CI was green. |
This flag allows heap snapshots to be captured without modifying application code. PR-URL: nodejs#27133 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Sam Roberts <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Anna Henningsen <[email protected]>
This flag allows heap snapshots to be captured without modifying application code. IMO, this is a big part of the "heapdump in core" use case.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes