Skip to content

build,win: bail vcbuild if mklink fails#27216

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
refack merged 1 commit into from
Apr 20, 2019
Merged

build,win: bail vcbuild if mklink fails #27216

refack merged 1 commit into from
Apr 20, 2019

Conversation

@refack
Copy link
Contributor

@refackrefack commented Apr 13, 2019

Refs: #27149 (comment)

Otherwise vcbuild will continue even if mklink fails, and will use old artifacts if present.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Apr 13, 2019

Lite-CI: https://ci.nodejs.org/job/node-test-pull-request-lite-pipeline/3243

@nodejs-github-botnodejs-github-bot added build Issues and PRs related to build files or the CI. windows Issues and PRs related to the Windows platform. labels Apr 13, 2019
@refackrefack requested a review from richardlauApril 13, 2019 14:12
@refackrefackforce-pushed the bail-vcbuild-if-mklink-fails branch from 772c4db to 1a39749CompareApril 13, 2019 14:16
refack
refack commented Apr 13, 2019
View reviewed changes
@nodejsnodejs deleted a comment from nodejs-github-botApr 13, 2019
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Apr 13, 2019

CI: https://ci.nodejs.org/job/node-test-pull-request/22412/

@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Apr 13, 2019

CI: https://ci.nodejs.org/job/node-test-pull-request/22414/

@refackrefack self-assigned this Apr 13, 2019
@refackrefackforce-pushed the bail-vcbuild-if-mklink-fails branch from b09360b to b72f24eCompareApril 14, 2019 17:20
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Apr 14, 2019

CI: https://ci.nodejs.org/job/node-test-pull-request/22431/

@refack
Copy link
ContributorAuthor

refack commented Apr 14, 2019

/CC @nodejs/build-files @nodejs/platform-windows

@refackrefack added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Apr 14, 2019
@refackrefackforce-pushed the bail-vcbuild-if-mklink-fails branch from b72f24e to 0fc27f6CompareApril 20, 2019 15:05
@refackrefack merged commit 0fc27f6 into nodejs:masterApr 20, 2019
@refackrefack removed the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Apr 20, 2019
@refackrefack removed their assignment Apr 20, 2019
@refackrefack deleted the bail-vcbuild-if-mklink-fails branch April 20, 2019 15:07
This was referenced Apr 23, 2019
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
@beevelopbeevelop mentioned this pull request Apr 23, 2019
Closed
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@richardlaurichardlaurichardlau approved these changes

Assignees

No one assigned

Labels

buildIssues and PRs related to build files or the CI.windowsIssues and PRs related to the Windows platform.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@refack@nodejs-github-bot@richardlau