worker: simplify filename checks#27233
Closed
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Replace a couple of checks with a single regular expression.
Collaborator
nodejs-github-bot commented Apr 14, 2019
richardlau approved these changes Apr 15, 2019
addaleax approved these changes Apr 15, 2019
jasnell approved these changes Apr 15, 2019
BridgeAR added the author ready Collaborator
nodejs-github-bot commented Apr 15, 2019
ZYSzys approved these changes Apr 17, 2019
Member
ZYSzys commented Apr 17, 2019
Landed in 5450e48 🎉 |
ZYSzys pushed a commit that referenced this pull request Apr 17, 2019
Replace a couple of checks with a single regular expression. PR-URL: #27233 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Yongsheng Zhang <[email protected]>
This was referenced Apr 23, 2019
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace a couple of checks with a single regular expression.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes