test: allow leaked global check to be skipped#27239
Closed
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
This simplifies the process of running tests on different versions of Node, which might have a different set of global variables.
Collaborator
nodejs-github-bot commented Apr 15, 2019
ContributorAuthor
cjihrig commented Apr 15, 2019
cc: @Trott |
Trott approved these changes Apr 15, 2019
Member
Trott left a comment
Trott left a comment There was a problem hiding this comment.
LGTM. Nit: Probably worth adding a note to test/common/README.md about it?
BridgeAR approved these changes Apr 15, 2019
BridgeAR added the author ready Collaborator
nodejs-github-bot commented Apr 15, 2019
addaleax approved these changes Apr 15, 2019
lpinca approved these changes Apr 15, 2019
Collaborator
nodejs-github-bot commented Apr 17, 2019
jasnell approved these changes Apr 17, 2019
Contributor
danbev commented Apr 19, 2019
Landed in 57ab3b5. |
danbev pushed a commit that referenced this pull request Apr 19, 2019
This simplifies the process of running tests on different versions of Node, which might have a different set of global variables. PR-URL: #27239 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: James M Snell <[email protected]>
This was referenced Apr 23, 2019
kt3k reviewed Mar 18, 2025
| if(process.env.NODE_TEST_KNOWN_GLOBALS!=='0'){ | ||
| if(process.env.NODE_TEST_KNOWN_GLOBALS){ | ||
| constknownFromEnv=process.env.NODE_TEST_KNOWN_GLOBALS.split(','); | ||
| allowGlobals(...knownFromEnv); |
Contributor
There was a problem hiding this comment.
Shouldn't this be something like:
allowGlobals(...knownFromEnv.map((name)=>globalThis[name]));Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This simplifies the process of running tests on different versions of Node, which might have a different set of global variables.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes