benchmark: add benchmark for dns.promises.lookup()#27249
Closed
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Collaborator
nodejs-github-bot commented Apr 16, 2019
nodejs-github-bot added benchmark 
richardlau approved these changes Apr 16, 2019
2 tasks
Trott added the author ready 
mihalskiy approved these changes Apr 16, 2019
addaleax approved these changes Apr 16, 2019
benchmark/dns/lookup-promises.js Outdated
Member
There was a problem hiding this comment.
If we’re using async/await anyway, would using a loop instead of recursive function calls make sense?
Trottforce-pushed the add-dns-lookup-promises-benchmark branch from 82af24d to 449eee0Compare
Adding this benchmark will let us check the performance implications of nodejs#27081.
Trottforce-pushed the add-dns-lookup-promises-benchmark branch from 449eee0 to 57a9ad9Compare
MemberAuthor
Trott commented Apr 18, 2019
ZYSzys approved these changes Apr 18, 2019
MemberAuthor
Trott commented Apr 18, 2019
Landed in f98679f |
Trott added a commit to Trott/io.js that referenced this pull request Apr 18, 2019
Adding this benchmark will let us check the performance implications of nodejs#27081. PR-URL: nodejs#27249 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Yongsheng Zhang <[email protected]>
This was referenced Apr 23, 2019
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adding this benchmark will let us check the performance implications of
#27081.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes