src: apply clang-tidy modernize-deprecated-headers found by Jenkins CI#27279
+13 −11
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
nodejs-github-bot added the c++ 
gengjiawenforce-pushed the deprecated_headers branch 2 times, most recently from 742af1b to 9884287Comparegengjiawen changed the title 
gengjiawenforce-pushed the deprecated_headers branch from 9884287 to 68b9d2dCompare
Collaborator
nodejs-github-bot commented Apr 18, 2019
MemberAuthor
gengjiawen commented Apr 18, 2019
addaleax approved these changes Apr 18, 2019
This was referenced Apr 20, 2019
Collaborator
nodejs-github-bot commented Apr 24, 2019
MemberAuthor
gengjiawen commented Apr 26, 2019
@danbev Can you merge this ? Thanks. |
Contributor
danbev commented Apr 26, 2019
Landed in 5fe4d59. |
danbev pushed a commit that referenced this pull request Apr 26, 2019
PR-URL: #27279 Reviewed-By: Anna Henningsen <[email protected]>
targos pushed a commit that referenced this pull request Apr 27, 2019
PR-URL: #27279 Reviewed-By: Anna Henningsen <[email protected]>
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Found by https://ci.nodejs.org/job/node-clang-tidy/7/console.
cc @refack
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes