test: increase coverage for dns.promises.lookup()#27299
Closed
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Add coverage for uv_getaddrinfo() returning an error.
Collaborator
nodejs-github-bot commented Apr 18, 2019
MemberAuthor
Trott commented Apr 18, 2019
This adds coverage for node/lib/internal/dns/promises.js Line 96 in d5bb500 |
Collaborator
nodejs-github-bot commented Apr 18, 2019
Trott added the author ready 
BridgeAR approved these changes Apr 19, 2019
test/parallel/test-dns-lookup.js Outdated
| assert.strictEqual(error.code,'ENOMEM'); | ||
| assert.strictEqual(error.hostname,'example.com'); | ||
| }) | ||
| ); |
Member
There was a problem hiding this comment.
Please use assert.rejects instead.
Collaborator
nodejs-github-bot commented Apr 19, 2019
cjihrig approved these changes Apr 19, 2019
MemberAuthor
Trott commented Apr 21, 2019
Landed in 7167eb2 |
Trott added a commit to Trott/io.js that referenced this pull request Apr 21, 2019
Add coverage for uv_getaddrinfo() returning an error. PR-URL: nodejs#27299 Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
This was referenced Apr 23, 2019
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add coverage for uv_getaddrinfo() returning an error.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes