test: add test-spawn-cmd-named-pipe#2770
Uh oh!
There was an error while loading. Please reload this page.
Conversation
mscdex added child_process 
orangemocha commented Sep 9, 2015
Thanks @cjihrig for all the feedback! I will revamp this test according to your suggestions. Can the Copyright notice really be removed? I don't think so. Even with a permissive license, one of the clauses is to preserve the copyright notice. |
cjihrig commented Sep 9, 2015
Yea, the copyright in all the files was removed a long time ago in io.js. I'm not a lawyer, but I think I remember something about only needing the license in the root of the project. |
orangemocha commented Sep 9, 2015
Ok, I'll take your word for it. |
orangemochaforce-pushed the orangemocha-testCmdNamedPipe branch from 0e0886b to e9003b2Compareorangemocha commented Sep 11, 2015
Updated. PTAL. |
cjihrig commented Sep 17, 2015
The commented out |
orangemochaforce-pushed the orangemocha-testCmdNamedPipe branch from e9003b2 to 46e1d9fCompareorangemocha commented Sep 17, 2015
Updated according to feedback. Thanks again for all the help! Much more slick now 👍 CI run: https://ci.nodejs.org/job/node-test-pull-request/333/ |
orangemocha commented Sep 17, 2015
argh.. linter errors |
Adding a Windows test to verify that a node process spawned via cmd with named pipes can access its stdio streams. Ref: nodejs/node-v0.x-archive#7345
orangemochaforce-pushed the orangemocha-testCmdNamedPipe branch from 46e1d9f to ab7d0b8Compareorangemocha commented Sep 17, 2015
Fixed whitespace. One more try: https://ci.nodejs.org/job/node-test-pull-request/334/ |
6 participants
Adding a Windows test to verify that a node process spawned via
cmd with named pipes can access its stdio streams.
Ref: nodejs/node-v0.x-archive#7345
This test was orphaned in joyent/node:master. It is still useful.