assert: remove unreachable code#27786
Closed
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Collaborator
nodejs-github-bot commented May 20, 2019
nodejs-github-bot added the assert 
BridgeAR approved these changes May 20, 2019
Trott added the author ready 
cjihrig approved these changes May 20, 2019
ZYSzys approved these changes May 21, 2019
This comment has been minimized.
This comment has been minimized.
richardlau approved these changes May 21, 2019
This comment has been minimized.
This comment has been minimized.
Collaborator
nodejs-github-bot commented May 21, 2019
trivikr approved these changes May 21, 2019
lpinca approved these changes May 21, 2019
Uh oh!
There was an error while loading. Please reload this page.
jasnell approved these changes May 23, 2019
In lib/internal/assert/assertion_error.js, line 391 assures that `operator` is 'deepEqual' so there is no need to check the value of `operator` in a ternary on the next line (line 392). Remove the ternary.
Trottforce-pushed the assertion-error-unreachable branch from 48cf267 to 082b9e0Compare This comment has been minimized.
This comment has been minimized.
Collaborator
nodejs-github-bot commented May 23, 2019
MemberAuthor
Trott commented May 23, 2019
Landed in 99268b1 |
Trott added a commit to Trott/io.js that referenced this pull request May 23, 2019
In lib/internal/assert/assertion_error.js, line 391 assures that `operator` is 'deepEqual' so there is no need to check the value of `operator` in a ternary on the next line (line 392). Remove the ternary. PR-URL: nodejs#27786 Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Yongsheng Zhang <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: James M Snell <[email protected]>
targos pushed a commit that referenced this pull request May 28, 2019
In lib/internal/assert/assertion_error.js, line 391 assures that `operator` is 'deepEqual' so there is no need to check the value of `operator` in a ternary on the next line (line 392). Remove the ternary. PR-URL: #27786 Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Yongsheng Zhang <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: James M Snell <[email protected]>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In lib/internal/assert/assertion_error.js, line 391 assures that
operatoris 'deepEqual' so there is no need to check the value ofoperatorin a ternary on the next line (line 392). Remove the ternary.Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes