child_process: remove extra shallow copy#27801
Closed
+1 −1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
nodejs-github-bot added the child_process 
cjihrig approved these changes May 21, 2019
BridgeAR approved these changes May 21, 2019
ZYSzys approved these changes May 21, 2019
Collaborator
nodejs-github-bot commented May 21, 2019
lpinca approved these changes May 21, 2019
jasnell approved these changes May 23, 2019
Collaborator
nodejs-github-bot commented May 23, 2019
ZYSzys added the author ready 
Contributor
danbev commented May 24, 2019
Re-run of failing node-test-commit-windows-fanned (✔️) |
Contributor
danbev commented May 24, 2019
Landed in 77b9ce5. |
danbev pushed a commit that referenced this pull request May 24, 2019
PR-URL: #27801 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Yongsheng Zhang <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: James M Snell <[email protected]>
targos pushed a commit that referenced this pull request May 28, 2019
PR-URL: #27801 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Yongsheng Zhang <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: James M Snell <[email protected]>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes