test: fix flaky test-https-agent-additional-options#27830
Closed
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
test-https-agent-additional-options is invoked with a command-line flag. However, there is an equivalent option that can be enabled within the code. Do that instead.
In test-https-agent-additional-options, use arrow functions for anonymous callbacks. Replace a use of `this` with the relevant constant.
Move callback to location where it is less confusing.
Collaborator
nodejs-github-bot commented May 22, 2019
Collaborator
nodejs-github-bot commented May 22, 2019
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
test-https-agent-additional-options can occasionally fail if a socket closes before the checks near the end of the test. Modify the test to check the freeSockets pool after each request. Fixes: nodejs#24449
This comment has been minimized.
This comment has been minimized.
MemberAuthor
Looks like the stress test rebuild didn't pick up the force-pushed changes. Let's try starting fresh: (And here's a stress test on master showing that it's flaky there: https://ci.nodejs.org/job/node-stress-single-test/2214/) |
MemberAuthor
Trott commented May 23, 2019
Hooray, that fixed it! Removing WIP label. /ping @nodejs/testing |
Collaborator
nodejs-github-bot commented May 23, 2019
Trott changed the title MemberAuthor
Trott commented May 24, 2019
@nodejs/collaborators This could use a review or two. Thanks! |
sam-github approved these changes May 24, 2019
lpinca approved these changes May 24, 2019
Trott added author ready Trott added a commit to Trott/io.js that referenced this pull request May 25, 2019
test-https-agent-additional-options is invoked with a command-line flag. However, there is an equivalent option that can be enabled within the code. Do that instead. PR-URL: nodejs#27830 Reviewed-By: Sam Roberts <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
Trott added a commit to Trott/io.js that referenced this pull request May 25, 2019
In test-https-agent-additional-options, use arrow functions for anonymous callbacks. Replace a use of `this` with the relevant constant. PR-URL: nodejs#27830 Reviewed-By: Sam Roberts <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
Trott added a commit to Trott/io.js that referenced this pull request May 25, 2019
Move callback to location where it is less confusing. PR-URL: nodejs#27830 Reviewed-By: Sam Roberts <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
Trott added a commit to Trott/io.js that referenced this pull request May 25, 2019
test-https-agent-additional-options can occasionally fail if a socket closes before the checks near the end of the test. Modify the test to check the freeSockets pool after each request. PR-URL: nodejs#27830Fixes: nodejs#24449 Reviewed-By: Sam Roberts <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
MemberAuthor
Trott commented May 25, 2019
Landed in 5b8df5e...0d28300 |
targos pushed a commit that referenced this pull request May 28, 2019
test-https-agent-additional-options is invoked with a command-line flag. However, there is an equivalent option that can be enabled within the code. Do that instead. PR-URL: #27830 Reviewed-By: Sam Roberts <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
targos pushed a commit that referenced this pull request May 28, 2019
In test-https-agent-additional-options, use arrow functions for anonymous callbacks. Replace a use of `this` with the relevant constant. PR-URL: #27830 Reviewed-By: Sam Roberts <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
targos pushed a commit that referenced this pull request May 28, 2019
Move callback to location where it is less confusing. PR-URL: #27830 Reviewed-By: Sam Roberts <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
targos pushed a commit that referenced this pull request May 28, 2019
test-https-agent-additional-options can occasionally fail if a socket closes before the checks near the end of the test. Modify the test to check the freeSockets pool after each request. PR-URL: #27830Fixes: #24449 Reviewed-By: Sam Roberts <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes