doc,n-api: fix typo in N-API introduction#27833
Closed
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Collaborator
nodejs-github-bot commented May 23, 2019
nodejs-github-bot added doc 
danbev approved these changes May 23, 2019
sam-github approved these changes May 23, 2019
richardlau added the author ready 
ZYSzys approved these changes May 23, 2019
jasnell approved these changes May 23, 2019
lpinca approved these changes May 23, 2019
cjihrig approved these changes May 23, 2019
trivikr approved these changes May 24, 2019
Trott approved these changes May 25, 2019
Member
Trott commented May 25, 2019
Landed in eb32e38 |
Trott pushed a commit to Trott/io.js that referenced this pull request May 25, 2019
PR-URL: nodejs#27833 Reviewed-By: Daniel Bevenius <[email protected]> Reviewed-By: Sam Roberts <[email protected]> Reviewed-By: Yongsheng Zhang <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]> Reviewed-By: Rich Trott <[email protected]>
targos pushed a commit that referenced this pull request May 28, 2019
PR-URL: #27833 Reviewed-By: Daniel Bevenius <[email protected]> Reviewed-By: Sam Roberts <[email protected]> Reviewed-By: Yongsheng Zhang <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]> Reviewed-By: Rich Trott <[email protected]>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
11 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes