Uh oh!
There was an error while loading. Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork 34.4k
add experimental wasi module support on top of wasm modules#27850
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Uh oh!
There was an error while loading. Please reload this page.
Conversation
devsnek commented May 24, 2019 • edited
Loading Uh oh!
There was an error while loading. Please reload this page.
edited
Uh oh!
There was an error while loading. Please reload this page.
nodejs-github-bot commented May 24, 2019 • edited
Loading Uh oh!
There was an error while loading. Please reload this page.
edited
Uh oh!
There was an error while loading. Please reload this page.
6cb5900 to 9304df9Comparedevsnek commented May 24, 2019
i tried to set up the |
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
test/wasi/README.md Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
\o/ \o/ Really excited this is testing and running vanilla clang/wasi-sysroot output.
addaleax left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎉
Uh oh!
There was an error while loading. Please reload this page.
ofrobots left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking great! Thanks for putting this together. I'm experimenting with some 'real world' code that relies on this over at https://github.com/ofrobots/brotli-wasm.
Uh oh!
There was an error while loading. Please reload this page.
4095270 to 8373c5dCompareUh oh!
There was an error while loading. Please reload this page.
syrusakbary commented May 31, 2019
This is awesome! Great work on the PR 👏 |
Trott commented Jun 1, 2019
Did this get resolved or is it still a problem? |
devsnek commented Jun 1, 2019
@Trott still a problem |
cjihrig commented Jun 1, 2019
@devsnek, rename |
devsnek commented Jun 2, 2019
@cjihrig i attempted to add seeking but the native function keeps returning undefined on success instead of the new offset ;(. if anyone better with napi sees the bug please let me know |
Uh oh!
There was an error while loading. Please reload this page.
This commit adds support for resolving symlinks during path resolution. This commit also ports all of the remaining tests from nodejs/node#27850, with the 'poll' test currently disabled.
This commit ports the following tests from nodejs/node#27850. - clock_getres - getentropy (currently disabled) - getrusage - gettimeofday - notdir - preopen_populates - read_file_twice - stat - stdin - write_file This commit completes the implementations of fd_filestat_get() and path_filestat_get(), which are needed for the stat test. This commit also adds clock_res_get() and partial clock_time_get() support.
This commit adds support for resolving symlinks during path resolution. This commit also ports all of the remaining tests from nodejs/node#27850, with the 'poll' test currently disabled.
This commit ports the following tests from nodejs/node#27850. - clock_getres - getentropy (currently disabled) - getrusage - gettimeofday - notdir - preopen_populates - read_file_twice - stat - stdin - write_file This commit completes the implementations of fd_filestat_get() and path_filestat_get(), which are needed for the stat test. This commit also adds clock_res_get() and partial clock_time_get() support.
This commit adds support for resolving symlinks during path resolution. This commit also ports all of the remaining tests from nodejs/node#27850, with the 'poll' test currently disabled.
This commit ports the following tests from nodejs/node#27850. - clock_getres - getentropy (currently disabled) - getrusage - gettimeofday - notdir - preopen_populates - read_file_twice - stat - stdin - write_file This commit completes the implementations of fd_filestat_get() and path_filestat_get(), which are needed for the stat test. This commit also adds clock_res_get() and partial clock_time_get() support.
This commit adds support for resolving symlinks during path resolution. This commit also ports all of the remaining tests from nodejs/node#27850, with the 'poll' test currently disabled.
This commit ports the following tests from nodejs/node#27850. - clock_getres - getentropy (currently disabled) - getrusage - gettimeofday - notdir - preopen_populates - read_file_twice - stat - stdin - write_file This commit completes the implementations of fd_filestat_get() and path_filestat_get(), which are needed for the stat test. This commit also adds clock_res_get() and partial clock_time_get() support.
This commit adds support for resolving symlinks during path resolution. This commit also ports all of the remaining tests from nodejs/node#27850, with the 'poll' test currently disabled.
This commit ports the following tests from nodejs/node#27850. - clock_getres - getentropy (currently disabled) - getrusage - gettimeofday - notdir - preopen_populates - read_file_twice - stat - stdin - write_file This commit completes the implementations of fd_filestat_get() and path_filestat_get(), which are needed for the stat test. This commit also adds clock_res_get() and partial clock_time_get() support.
This commit adds support for resolving symlinks during path resolution. This commit also ports all of the remaining tests from nodejs/node#27850, with the 'poll' test currently disabled.
This commit ports the following tests from nodejs/node#27850. - clock_getres - getentropy (currently disabled) - getrusage - gettimeofday - notdir - preopen_populates - read_file_twice - stat - stdin - write_file This commit completes the implementations of fd_filestat_get() and path_filestat_get(), which are needed for the stat test. This commit also adds clock_res_get() and partial clock_time_get() support.
This commit adds support for resolving symlinks during path resolution. This commit also ports all of the remaining tests from nodejs/node#27850, with the 'poll' test currently disabled.
This commit ports the following tests from nodejs/node#27850. - clock_getres - getentropy (currently disabled) - getrusage - gettimeofday - notdir - preopen_populates - read_file_twice - stat - stdin - write_file This commit completes the implementations of fd_filestat_get() and path_filestat_get(), which are needed for the stat test. This commit also adds clock_res_get() and partial clock_time_get() support.
This commit adds support for resolving symlinks during path resolution. This commit also ports all of the remaining tests from nodejs/node#27850, with the 'poll' test currently disabled.
This commit ports the following tests from nodejs/node#27850. - clock_getres - getentropy (currently disabled) - getrusage - gettimeofday - notdir - preopen_populates - read_file_twice - stat - stdin - write_file This commit completes the implementations of fd_filestat_get() and path_filestat_get(), which are needed for the stat test. This commit also adds clock_res_get() and partial clock_time_get() support.
This commit adds support for resolving symlinks during path resolution. This commit also ports all of the remaining tests from nodejs/node#27850, with the 'poll' test currently disabled.
This commit ports the following tests from nodejs/node#27850. - clock_getres - getentropy (currently disabled) - getrusage - gettimeofday - notdir - preopen_populates - read_file_twice - stat - stdin - write_file This commit completes the implementations of fd_filestat_get() and path_filestat_get(), which are needed for the stat test. This commit also adds clock_res_get() and partial clock_time_get() support.
This commit adds support for resolving symlinks during path resolution. This commit also ports all of the remaining tests from nodejs/node#27850, with the 'poll' test currently disabled.
Co-authored-by: Gus Caplan <[email protected]> Co-authored-by: Daniel Bevenius <[email protected]> Co-authored-by: Jiawen Geng <[email protected]> Co-authored-by: Tobias Nießen <[email protected]> Co-authored-by: Chengzhong Wu <[email protected]> PR-URL: #30258 Refs: #27850 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Saúl Ibarra Corretgé <[email protected]> Reviewed-By: Guy Bedford <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Wyatt Preul <[email protected]> Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: Jiawen Geng <[email protected]> Reviewed-By: Chengzhong Wu <[email protected]> Reviewed-By: Daniel Bevenius <[email protected]>
Co-authored-by: Gus Caplan <[email protected]> Co-authored-by: Daniel Bevenius <[email protected]> Co-authored-by: Jiawen Geng <[email protected]> Co-authored-by: Tobias Nießen <[email protected]> Co-authored-by: Chengzhong Wu <[email protected]> PR-URL: #30258 Refs: #27850 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Saúl Ibarra Corretgé <[email protected]> Reviewed-By: Guy Bedford <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Wyatt Preul <[email protected]> Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: Jiawen Geng <[email protected]> Reviewed-By: Chengzhong Wu <[email protected]> Reviewed-By: Daniel Bevenius <[email protected]>
Co-authored-by: Gus Caplan <[email protected]> Co-authored-by: Daniel Bevenius <[email protected]> Co-authored-by: Jiawen Geng <[email protected]> Co-authored-by: Tobias Nießen <[email protected]> Co-authored-by: Chengzhong Wu <[email protected]> PR-URL: #30258 Refs: #27850 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Saúl Ibarra Corretgé <[email protected]> Reviewed-By: Guy Bedford <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Wyatt Preul <[email protected]> Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: Jiawen Geng <[email protected]> Reviewed-By: Chengzhong Wu <[email protected]> Reviewed-By: Daniel Bevenius <[email protected]>
Co-authored-by: Gus Caplan <[email protected]> Co-authored-by: Daniel Bevenius <[email protected]> Co-authored-by: Jiawen Geng <[email protected]> Co-authored-by: Tobias Nießen <[email protected]> Co-authored-by: Chengzhong Wu <[email protected]> PR-URL: #30258 Refs: #27850 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Saúl Ibarra Corretgé <[email protected]> Reviewed-By: Guy Bedford <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Wyatt Preul <[email protected]> Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: Jiawen Geng <[email protected]> Reviewed-By: Chengzhong Wu <[email protected]> Reviewed-By: Daniel Bevenius <[email protected]>
@lukewagner@linclark@guybedford@tschneidereit@ofrobots
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes