Skip to content

Conversation

@lpinca
Copy link
Member

value -> chunk.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • documentation is changed or added
  • commit message follows commit guidelines

@nodejs-github-bot

This comment has been minimized.

@nodejs-github-bot
Copy link
Collaborator

@TrottTrott added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label May 27, 2019
@lpinca
Copy link
MemberAuthor

Landed in eb4c1d5.

@lpincalpinca closed this May 29, 2019
@lpincalpinca deleted the fix/typo branch May 29, 2019 06:43
lpinca added a commit that referenced this pull request May 29, 2019
PR-URL: #27870 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Yongsheng Zhang <[email protected]> Reviewed-By: Anto Aravinth <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Anna Henningsen <[email protected]>
targos pushed a commit that referenced this pull request May 31, 2019
PR-URL: #27870 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Yongsheng Zhang <[email protected]> Reviewed-By: Anto Aravinth <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Anna Henningsen <[email protected]>
@targostargos mentioned this pull request Jun 3, 2019
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author readyPRs that have at least one approval, no pending requests for changes, and a CI started.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants

@lpinca@nodejs-github-bot@Trott@addaleax@antsmartian@cjihrig@ZYSzys