Skip to content

src: make UNREACHABLE variadic#27877

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
refack merged 1 commit into from
May 29, 2019
Merged

src: make UNREACHABLE variadic #27877

refack merged 1 commit into from
May 29, 2019

Conversation

@refack
Copy link
Contributor

@refackrefack commented May 25, 2019•
edited
Loading

Eliminate warning C4003 (not enough arguments for function-like macro invocation 'UNREACHABLE') which is raised 101 times per build by MSVC.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • documentation is changed or added
  • commit message follows commit guidelines

@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented May 25, 2019

CI: https://ci.nodejs.org/job/node-test-pull-request/23328/

@refackrefack self-assigned this May 25, 2019
@refackrefack added lib / src Issues and PRs related to general changes in the lib or src directory. c++ Issues and PRs that require attention from people who are familiar with C++. labels May 25, 2019
@refack
Copy link
ContributorAuthor

refack commented May 28, 2019

/CC @nodejs/platform-windows
/CC @nitsakh@danbev@addaleax who last worked on this file

@refackrefack added the review wanted PRs that need reviews. label May 28, 2019
@BridgeARBridgeAR added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label May 29, 2019
@refackrefack removed author ready PRs that have at least one approval, no pending requests for changes, and a CI started. review wanted PRs that need reviews. labels May 29, 2019
@refack
src: make UNREACHABLE variadic
7329c8f
Eliminate warning C4003 - not enough arguments for function-like macro invocation 'UNREACHABLE' PR-URL: nodejs#27877 Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: Daniel Bevenius <[email protected]>
@refackrefackforce-pushed the variadic-unreachable branch from de79a3d to 7329c8fCompareMay 29, 2019 17:05
@refackrefack removed their assignment May 29, 2019
@refackrefack merged commit 7329c8f into nodejs:masterMay 29, 2019
@refackrefack deleted the variadic-unreachable branch May 29, 2019 17:07
targos pushed a commit that referenced this pull request May 31, 2019
@refack@targos
src: make UNREACHABLE variadic
b9cc407
Eliminate warning C4003 - not enough arguments for function-like macro invocation 'UNREACHABLE' PR-URL: #27877 Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: Daniel Bevenius <[email protected]>
@targostargos mentioned this pull request Jun 3, 2019
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tniessentniessentniessen approved these changes

+1 more reviewer

@danbevdanbevdanbev approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

c++Issues and PRs that require attention from people who are familiar with C++.lib / srcIssues and PRs related to general changes in the lib or src directory.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@refack@nodejs-github-bot@danbev@tniessen@BridgeAR