test: rsa-pss generateKeyPairSync invalid option hash#27883
Closed
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
ryzokuken added the code-and-learn 
ryzokuken approved these changes May 26, 2019
addaleax approved these changes May 26, 2019
BridgeAR approved these changes May 26, 2019
cjihrig approved these changes May 26, 2019
Trott approved these changes May 27, 2019
Collaborator
nodejs-github-bot commented May 27, 2019
Trott added the author ready 
tniessen approved these changes May 27, 2019
Member
tniessen left a comment
tniessen left a comment There was a problem hiding this comment.
Thanks for the ping, I appreciate it.
Collaborator
nodejs-github-bot commented May 30, 2019
Member
Trott commented May 30, 2019
Landed in 1279d51 |
Trott pushed a commit to Trott/io.js that referenced this pull request May 30, 2019
PR-URL: nodejs#27883 Reviewed-By: Ujjwal Sharma <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Tobias Nießen <[email protected]>
targos pushed a commit that referenced this pull request May 31, 2019
PR-URL: #27883 Reviewed-By: Ujjwal Sharma <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Tobias Nießen <[email protected]>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes