test: switch actual value argument and expected in deepStrictEqual call#27888
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
addaleax approved these changes May 26, 2019
ryzokuken approved these changes May 26, 2019
Contributor
ryzokuken left a comment
ryzokuken left a comment There was a problem hiding this comment.
LGTM. Thanks for the PR.
ryzokuken added the code-and-learn 
BridgeAR approved these changes May 26, 2019
cjihrig approved these changes May 26, 2019
ChALkeR approved these changes May 26, 2019
Trott approved these changes May 27, 2019
Trott added the author ready 
Collaborator
nodejs-github-bot commented May 27, 2019
gireeshpunathil approved these changes May 27, 2019
Collaborator
nodejs-github-bot commented May 27, 2019
Member
ChALkeR commented May 27, 2019
Please react with 👍for fast-tracking. |
ZYSzys approved these changes May 27, 2019
Replace deepStrictEqual call to have actual value as the first argument and the expected value as the second. Change expectedRecvData definition in single place. PR-URL: nodejs#27888 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Ujjwal Sharma <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Сковорода Никита Андреевич <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Gireesh Punathil <[email protected]> Reviewed-By: Yongsheng Zhang <[email protected]>
Member
ChALkeR commented May 27, 2019
Landed in 55de6ff. Thanks for the contribution! 🎉 https://www.nodetodo.org/next-steps/ is a good list of ideas on possible next steps. (But the next steps are not limited to just that list -- you can always come up with your own)! |
targos pushed a commit that referenced this pull request May 28, 2019
Replace deepStrictEqual call to have actual value as the first argument and the expected value as the second. Change expectedRecvData definition in single place. PR-URL: #27888 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Ujjwal Sharma <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Сковорода Никита Андреевич <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Gireesh Punathil <[email protected]> Reviewed-By: Yongsheng Zhang <[email protected]>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
10 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace deepStrictEqual call to have actual value as the first argument
and the expected value as the second.
Change expectedRecvData definition in single place.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes