lib: removed unnecessary fs.realpath options arg check + tests#27909
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Removed duplicated check for options argument of fs.realpath. Added some tests which covering the cases for passing options arg as null.
nodejs-github-bot added the fs 
ryzokuken added the code-and-learn 
Collaborator
nodejs-github-bot commented May 27, 2019
ChALkeR added the author ready 
BridgeAR approved these changes May 29, 2019
Member
BridgeAR left a comment
BridgeAR left a comment There was a problem hiding this comment.
LGTM. Good work! Ideally we could reuse the other test cases and pass through different arguments but it is also fine as is!
trivikr approved these changes May 29, 2019
Trott approved these changes May 30, 2019
Collaborator
nodejs-github-bot commented May 30, 2019
Contributor
ryzokuken commented May 30, 2019
Landed in 490c7e0 🎉 |
ryzokuken pushed a commit that referenced this pull request May 30, 2019
Removed duplicated check for options argument of fs.realpath. Added some tests which covering the cases for passing options arg as null. PR-URL: #27909 Reviewed-By: Ujjwal Sharma <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]> Reviewed-By: Rich Trott <[email protected]>
targos pushed a commit that referenced this pull request May 31, 2019
Removed duplicated check for options argument of fs.realpath. Added some tests which covering the cases for passing options arg as null. PR-URL: #27909 Reviewed-By: Ujjwal Sharma <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]> Reviewed-By: Rich Trott <[email protected]>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removed duplicated check for options argument of fs.realpath.
Added some tests which covering the cases for passing options arg
as null.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes