Skip to content

test: switch assertEqual arguments#27912

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
ChALkeR merged 1 commit into from
May 28, 2019
Merged

test: switch assertEqual arguments #27912

ChALkeR merged 1 commit into from
May 28, 2019

Conversation

@zeckson
Copy link
Contributor

@zecksonzeckson commented May 26, 2019

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines

@nodejs-github-botnodejs-github-bot added the test Issues and PRs related to the tests. label May 26, 2019
@ChALkeRChALkeR added the code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. label May 26, 2019
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented May 27, 2019

CI: https://ci.nodejs.org/job/node-test-pull-request/23377/

@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented May 27, 2019

CI: https://ci.nodejs.org/job/node-test-pull-request/23400/

@ChALkeRChALkeR added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label May 27, 2019
@zeckson@ChALkeR
test: switch assertEqual arguments
b810607
PR-URL: nodejs#27912 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Gireesh Punathil <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Сковорода Никита Андреевич <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
@ChALkeRChALkeRforce-pushed the fix-assert-gh-892 branch from c151d50 to b810607CompareMay 28, 2019 20:43
@ChALkeRChALkeR merged commit b810607 into nodejs:masterMay 28, 2019
@ChALkeR
Copy link
Member

ChALkeR commented May 28, 2019

Landed in b810607, thanks for the contribution! 🎉

targos pushed a commit that referenced this pull request May 31, 2019
@zeckson@targos
test: switch assertEqual arguments
2a509d4
PR-URL: #27912 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Gireesh Punathil <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Сковорода Никита Андреевич <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
@targostargos mentioned this pull request Jun 3, 2019
Merged
@zecksonzeckson deleted the fix-assert-gh-892 branch June 18, 2019 15:10
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@TrottTrottTrott approved these changes

@addaleaxaddaleaxaddaleax approved these changes

@lpincalpincalpinca approved these changes

@cjihrigcjihrigcjihrig approved these changes

@gireeshpunathilgireeshpunathilgireeshpunathil approved these changes

+1 more reviewer

@ChALkeRChALkeRChALkeR approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

author readyPRs that have at least one approval, no pending requests for changes, and a CI started.code-and-learnIssues related to the Code-and-Learn events and PRs submitted during the events.testIssues and PRs related to the tests.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

@zeckson@nodejs-github-bot@ChALkeR@Trott@addaleax@lpinca@cjihrig@gireeshpunathil