Skip to content

[v10.x] tls: support TLS min/max protocol defaults in CLI#27946

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
sam-github wants to merge 1 commit into from
Closed

[v10.x] tls: support TLS min/max protocol defaults in CLI #27946

sam-github wants to merge 1 commit into from

Conversation

@sam-github
Copy link
Contributor

@sam-githubsam-github commented May 29, 2019

See #27666 and #27432 (comment)

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

@sam-github
Copy link
ContributorAuthor

sam-github commented May 29, 2019

/cc @nodejs/lts

richardlau
richardlau reviewed May 29, 2019
View reviewed changes
@mscdexmscdex added tls Issues and PRs related to the tls subsystem. v10.x labels May 29, 2019
@addaleaxaddaleax changed the title tls: support TLS min/max protocol defaults in CLI[v10.x] tls: support TLS min/max protocol defaults in CLIMay 29, 2019
bnoordhuis
bnoordhuis approved these changes Jun 1, 2019
View reviewed changes
@sam-githubsam-githubforce-pushed the tls-min-max-cli-v10.x branch from 5fb1f1a to b329d2aCompareJune 4, 2019 19:00
@nodejs-github-bot

This comment has been minimized.

Sign in to view
@sam-githubsam-githubforce-pushed the tls-min-max-cli-v10.x branch 3 times, most recently from a5884ed to 436b0ddCompareJune 5, 2019 16:56
@nodejs-github-bot

This comment has been minimized.

Sign in to view
@nodejs-github-bot

This comment has been minimized.

Sign in to view
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Jun 7, 2019

CI: https://ci.nodejs.org/job/node-test-pull-request/23694/

@BethGriggs
Copy link
Member

BethGriggs commented Jun 7, 2019

Latest CI shows a relevant failure https://ci.nodejs.org/job/node-test-commit-linux-containered/nodes=ubuntu1604_sharedlibs_openssl110_x64/

not ok 1812 parallel/test-tls-cli-min-version-1.1 14:47:18 --- 14:47:18 duration_ms: 0.419 14:47:18 severity: fail 14:47:18 exitcode: 1 14:47:18 stack: |- 14:47:18 test: U U U U U SSLv2_method expect U U ERR_TLS_INVALID_PROTOCOL_METHOD 14:47:18 (/home/iojs/build/workspace/node-test-commit-linux-containered/test/parallel/test-tls-min-max-version.js:108:1) 14:47:18 client undefined 14:47:18 server SSLv2 methods disabled 14:47:18 test: U U U U U SSLv3_method expect U U ERR_TLS_INVALID_PROTOCOL_METHOD 14:47:18 (/home/iojs/build/workspace/node-test-commit-linux-containered/test/parallel/test-tls-min-max-version.js:110:1) 14:47:18 client undefined 14:47:18 server SSLv3 methods disabled 14:47:18 test: U U U U U hokey-pokey expect U U ERR_TLS_INVALID_PROTOCOL_METHOD 14:47:18 (/home/iojs/build/workspace/node-test-commit-linux-containered/test/parallel/test-tls-min-max-version.js:118:1) 14:47:18 client undefined 14:47:18 server Unknown method 14:47:18 test: U U U U TLSv1.2 TLS1_2_method expect U U ERR_TLS_PROTOCOL_VERSION_CONFLICT 14:47:18 (/home/iojs/build/workspace/node-test-commit-linux-containered/test/parallel/test-tls-min-max-version.js:122:1) 14:47:18 client undefined 14:47:18 server ERR_TLS_PROTOCOL_VERSION_CONFLICT 14:47:18 test: U U U TLSv1.2 U TLS1_2_method expect U U ERR_TLS_PROTOCOL_VERSION_CONFLICT 14:47:18 (/home/iojs/build/workspace/node-test-commit-linux-containered/test/parallel/test-tls-min-max-version.js:124:1) 14:47:18 client undefined 14:47:18 server ERR_TLS_PROTOCOL_VERSION_CONFLICT 14:47:18 test: U U SSLv2_method U U U expect U ERR_TLS_INVALID_PROTOCOL_METHOD U 14:47:18 (/home/iojs/build/workspace/node-test-commit-linux-containered/test/parallel/test-tls-min-max-version.js:112:1) 14:47:18 client SSLv2 methods disabled 14:47:18 server undefined 14:47:18 test: U U SSLv3_method U U U expect U ERR_TLS_INVALID_PROTOCOL_METHOD U 14:47:18 (/home/iojs/build/workspace/node-test-commit-linux-containered/test/parallel/test-tls-min-max-version.js:114:1) 14:47:18 client SSLv3 methods disabled 14:47:18 server undefined 14:47:18 test: U U hokey-pokey U U U expect U ERR_TLS_INVALID_PROTOCOL_METHOD U 14:47:18 (/home/iojs/build/workspace/node-test-commit-linux-containered/test/parallel/test-tls-min-max-version.js:116:1) 14:47:18 client Unknown method 14:47:18 server undefined 14:47:18 test: U TLSv1.2 TLS1_2_method U U U expect U ERR_TLS_PROTOCOL_VERSION_CONFLICT U 14:47:18 (/home/iojs/build/workspace/node-test-commit-linux-containered/test/parallel/test-tls-min-max-version.js:126:1) 14:47:18 client ERR_TLS_PROTOCOL_VERSION_CONFLICT 14:47:18 server undefined 14:47:18 test: TLSv1.2 U TLS1_2_method U U U expect U ERR_TLS_PROTOCOL_VERSION_CONFLICT U 14:47:18 (/home/iojs/build/workspace/node-test-commit-linux-containered/test/parallel/test-tls-min-max-version.js:128:1) 14:47:18 client ERR_TLS_PROTOCOL_VERSION_CONFLICT 14:47:18 server undefined 14:47:18 test: U U TLSv1_method U U SSLv23_method expect U ECONNRESET ERR_SSL_UNSUPPORTED_PROTOCOL 14:47:18 (/home/iojs/build/workspace/node-test-commit-linux-containered/test/parallel/test-tls-min-max-version.js:156:3) 14:47:18 client ECONNRESET 14:47:18 server ERR_SSL_UNSUPPORTED_PROTOCOL 14:47:18 test: U U TLSv1_method U U U expect U ECONNRESET ERR_SSL_UNSUPPORTED_PROTOCOL 14:47:18 (/home/iojs/build/workspace/node-test-commit-linux-containered/test/parallel/test-tls-min-max-version.js:196:3) 14:47:18 client ECONNRESET 14:47:18 server ERR_SSL_UNSUPPORTED_PROTOCOL 14:47:18 test: U U SSLv23_method U U TLSv1_method expect U ERR_SSL_UNSUPPORTED_PROTOCOL ERR_SSL_WRONG_VERSION_NUMBER 14:47:18 (/home/iojs/build/workspace/node-test-commit-linux-containered/test/parallel/test-tls-min-max-version.js:159:3) 14:47:18 client 139923555178304:error:1417118C:SSL routines:tls_process_server_hello:version too low:ssl/statem/statem_clnt.c:932: 14:47:18 14:47:18 server ERR_SSL_WRONG_VERSION_NUMBER 14:47:18 assert.js:84 14:47:18 throw new AssertionError(obj); 14:47:18 ^ 14:47:18 14:47:18 AssertionError [ERR_ASSERTION]: Input A expected to strictly equal input B: 14:47:18 + expected - actual 14:47:18 14:47:18 - '139923555178304:error:1417118C:SSL routines:tls_process_server_hello:version too low:ssl/statem/statem_clnt.c:932:\n' 14:47:18 + 'ERR_SSL_UNSUPPORTED_PROTOCOL' 14:47:18 at common.mustCall (/home/iojs/build/workspace/node-test-commit-linux-containered/test/parallel/test-tls-min-max-version.js:82:16) 14:47:18 at /home/iojs/build/workspace/node-test-commit-linux-containered/test/common/index.js:379:15 14:47:18 at /home/iojs/build/workspace/node-test-commit-linux-containered/test/common/index.js:379:15 14:47:18 at maybeCallback (/home/iojs/build/workspace/node-test-commit-linux-containered/test/fixtures/tls-connect.js:97:7) 14:47:18 at Server.<anonymous> (/home/iojs/build/workspace/node-test-commit-linux-containered/test/fixtures/tls-connect.js:84:7) 14:47:18 at Server.emit (events.js:198:13) 14:47:18 at TLSSocket.onSocketTLSError (_tls_wrap.js:751:29) 14:47:18 at TLSSocket.emit (events.js:198:13) 14:47:18 at TLSSocket._tlsError (_tls_wrap.js:615:8) 14:47:18 at TLSSocket.emit (events.js:198:13) 14:47:18 ...

@sam-githubsam-githubforce-pushed the tls-min-max-cli-v10.x branch from 436b0dd to f269280CompareJune 7, 2019 17:33
@sam-github
Copy link
ContributorAuthor

sam-github commented Jun 7, 2019•
edited
Loading

Strangely, I could repro when I built against external openssl 1.1.0j. I'll have to do more digging to see what CI is doing. EDIT: I meant could not repro

@sam-github
Copy link
ContributorAuthor

sam-github commented Jun 7, 2019

I'm trying to verify what version of OpenSSL 1.1.0 was used in the failed job above. @richardlau do you know how I would work through the build system to find out?

I tried checking the workspace, https://ci.nodejs.org/job/node-test-commit-linux-containered/nodes=ubuntu1604_sharedlibs_openssl110_x64/ws/config.gypi/*view*/, but the include_dirs in config.gypi don't appear to contain an external openssl path, and config.status doesn't show signs of --shared-openssl being used, so that workspace is probably not what I think.

If its a docker container, I should be able to run it on my laptop, and repro the build.

@richardlau do you have any suggestions on how to find the docker container, or any information on how the docker container is configured?

@richardlau
Copy link
Member

richardlau commented Jun 7, 2019

@sam-github Walking through the links from https://ci.nodejs.org/job/node-test-pull-request/23694/ the full console log of the failing build being referenced is https://ci.nodejs.org/job/node-test-commit-linux-containered/13265/nodes=ubuntu1604_sharedlibs_openssl110_x64/consoleFull

python ./configure --verbose --shared-openssl --shared-openssl-includes=/opt/openssl-1.1.0j/include/ --shared-openssl-libpath=/opt/openssl-1.1.0j/lib/

The docker container configuration is in the build repo: https://github.com/nodejs/build/blob/master/ansible/roles/docker/templates/ubuntu1604_sharedlibs.Dockerfile.j2

@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Jun 8, 2019

CI: https://ci.nodejs.org/job/node-test-pull-request/23709/

@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Jun 10, 2019

CI: https://ci.nodejs.org/job/node-test-pull-request/23765/

@sam-github
Copy link
ContributorAuthor

sam-github commented Jun 10, 2019

Strangely, I just cannot reproduce this locally building against the same shared openssl version. I'm trying to build&run the docker image locally.

@BethGriggsBethGriggs added the semver-minor PRs that contain new features and should be released in the next minor version. label Jun 28, 2019
@sam-githubsam-github mentioned this pull request Jul 23, 2019
Closed
@nodejs-github-bot

This comment has been minimized.

Sign in to view
@nodejs-github-bot

This comment has been minimized.

Sign in to view
@nodejs-github-bot

This comment has been minimized.

Sign in to view
@BethGriggs
Copy link
Member

BethGriggs commented Feb 24, 2020•
edited
Loading

@sam-github I've just cherry-picked some additional 'mark as flaky' commits on to v10.x-staging. Hopefully, CI will be better now 🤞

@nodejs-github-bot

This comment has been minimized.

Sign in to view
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Feb 24, 2020

CI: https://ci.nodejs.org/job/node-test-pull-request/29322/

@BethGriggs
Copy link
Member

BethGriggs commented Feb 24, 2020

Added #27500 to v10.x, hopefully, clears up the last error.

@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Feb 24, 2020•
edited by BethGriggs
Loading

CI: https://ci.nodejs.org/job/node-test-pull-request/29327/ 🎉

BethGriggs pushed a commit that referenced this pull request Feb 25, 2020
@sam-github@BethGriggs
tls: support TLS min/max protocol defaults in CLI
1cfb457
Backport CLI switches for default TLS versions: - `--tls-max-v1.2` - `--tls-min-v1.0` - `--tls-min-v1.1` - `--tls-min-v1.2` PR-URL: #27946 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: Beth Griggs <[email protected]> Reviewed-By: Shelley Vohr <[email protected]>
@BethGriggs
Copy link
Member

BethGriggs commented Feb 25, 2020

Landed in 1cfb457

@sam-github
Copy link
ContributorAuthor

sam-github commented Feb 25, 2020

Yay!

@sam-githubsam-github deleted the tls-min-max-cli-v10.x branch February 25, 2020 00:40
BethGriggs added a commit that referenced this pull request Mar 10, 2020
@BethGriggs
2020-03-17, Version 10.20.0 'Dubnium' (LTS)
0e55404
Notable changes: - buffer: add{read|write}Big\[U\]Int64{BE|LE} methods (garygsc) [#19691](#19691) - deps: - upgrade to libuv 1.34.2 (cjihrig) [#31477](#31477) - upgrade npm to 6.13.7 (Michael Perrotte) [#31558](#31558) - n-api: - add napi\_get\_all\_property\_names (himself65) [#30006](#30006) - add APIs for per-instance state management (Gabriel Schulhof) [#28682](#28682) - turn NAPI\_CALL\_INTO\_MODULE into a function (Anna Henningsen) [#26128](#26128) - tls: support TLS min/max protocol defaults in CLI (Sam Roberts) [#27946](#27946) PR-URL: #31984
BethGriggs added a commit that referenced this pull request Mar 12, 2020
@BethGriggs
2020-03-17, Version 10.20.0 'Dubnium' (LTS)
889fa8c
Notable changes: - buffer: add{read|write}Big\[U\]Int64{BE|LE} methods (garygsc) [#19691](#19691) - deps: - upgrade to libuv 1.34.2 (cjihrig) [#31477](#31477) - upgrade npm to 6.13.7 (Michael Perrotte) [#31558](#31558) - n-api: - add napi\_get\_all\_property\_names (himself65) [#30006](#30006) - add APIs for per-instance state management (Gabriel Schulhof) [#28682](#28682) - turn NAPI\_CALL\_INTO\_MODULE into a function (Anna Henningsen) [#26128](#26128) - tls: - expose keylog event on TLSSocket (Alba Mendez) [#27654](#27654) - support TLS min/max protocol defaults in CLI (Sam Roberts) [#27946](#27946) PR-URL: #31984
@BethGriggsBethGriggs mentioned this pull request Mar 12, 2020
Merged
BethGriggs added a commit that referenced this pull request Mar 23, 2020
@BethGriggs
2020-03-24, Version 10.20.0 'Dubnium' (LTS)
5f10b71
Notable changes: - buffer: add{read|write}Big\[U\]Int64{BE|LE} methods (garygsc) [#19691](#19691) - deps: - update npm to 6.14.3 (Myles Borins) [#32368](#32368) - upgrade to libuv 1.34.2 (cjihrig) [#31477](#31477) - n-api: - add napi\_get\_all\_property\_names (himself65) [#30006](#30006) - add APIs for per-instance state management (Gabriel Schulhof) [#28682](#28682) - turn NAPI\_CALL\_INTO\_MODULE into a function (Anna Henningsen) [#26128](#26128) - tls: - expose keylog event on TLSSocket (Alba Mendez) [#27654](#27654) - support TLS min/max protocol defaults in CLI (Sam Roberts) [#27946](#27946) PR-URL: #31984
BethGriggs added a commit that referenced this pull request Mar 23, 2020
@BethGriggs
2020-03-24, Version 10.20.0 'Dubnium' (LTS)
3a9d15f
Notable changes: - buffer: add{read|write}Big\[U\]Int64{BE|LE} methods (garygsc) [#19691](#19691) - deps: - update npm to 6.14.3 (Myles Borins) [#32368](#32368) - upgrade to libuv 1.34.2 (cjihrig) [#31477](#31477) - n-api: - add napi\_get\_all\_property\_names (himself65) [#30006](#30006) - add APIs for per-instance state management (Gabriel Schulhof) [#28682](#28682) - turn NAPI\_CALL\_INTO\_MODULE into a function (Anna Henningsen) [#26128](#26128) - tls: - expose keylog event on TLSSocket (Alba Mendez) [#27654](#27654) - support TLS min/max protocol defaults in CLI (Sam Roberts) [#27946](#27946) PR-URL: #31984
BethGriggs added a commit that referenced this pull request Mar 24, 2020
@BethGriggs
2020-03-24, Version 10.20.0 'Dubnium' (LTS)
22927bf
Notable changes: - buffer: add{read|write}Big\[U\]Int64{BE|LE} methods (garygsc) [#19691](#19691) - deps: - update npm to 6.14.3 (Myles Borins) [#32368](#32368) - upgrade openssl sources to 1.1.1e (Hassaan Pasha) [#32328](#32328) - upgrade to libuv 1.34.2 (cjihrig) [#31477](#31477) - n-api: - add napi\_get\_all\_property\_names (himself65) [#30006](#30006) - add APIs for per-instance state management (Gabriel Schulhof) [#28682](#28682) - turn NAPI\_CALL\_INTO\_MODULE into a function (Anna Henningsen) [#26128](#26128) - tls: - expose keylog event on TLSSocket (Alba Mendez) [#27654](#27654) - support TLS min/max protocol defaults in CLI (Sam Roberts) [#27946](#27946) - url: handle quasi-WHATWG URLs in urlToOptions() (cjihrig) [#26226](#26226) PR-URL: #31984
BethGriggs added a commit that referenced this pull request Mar 25, 2020
@BethGriggs
2020-03-25, Version 10.20.0 'Dubnium' (LTS)
f5f4a75
Notable changes: - buffer: add{read|write}Big\[U\]Int64{BE|LE} methods (garygsc) [#19691](#19691) - deps: - update npm to 6.14.3 (Myles Borins) [#32368](#32368) - upgrade openssl sources to 1.1.1e (Hassaan Pasha) [#32328](#32328) - upgrade to libuv 1.34.2 (cjihrig) [#31477](#31477) - n-api: - add napi\_get\_all\_property\_names (himself65) [#30006](#30006) - add APIs for per-instance state management (Gabriel Schulhof) [#28682](#28682) - turn NAPI\_CALL\_INTO\_MODULE into a function (Anna Henningsen) [#26128](#26128) - tls: - expose keylog event on TLSSocket (Alba Mendez) [#27654](#27654) - support TLS min/max protocol defaults in CLI (Sam Roberts) [#27946](#27946) - url: handle quasi-WHATWG URLs in urlToOptions() (cjihrig) [#26226](#26226) PR-URL: #31984
BethGriggs added a commit that referenced this pull request Mar 26, 2020
@BethGriggs
2020-03-26, Version 10.20.0 'Dubnium' (LTS)
314adeb
Notable changes: - buffer: add{read|write}Big\[U\]Int64{BE|LE} methods (garygsc) [#19691](#19691) - deps: - update npm to 6.14.3 (Myles Borins) [#32368](#32368) - upgrade openssl sources to 1.1.1e (Hassaan Pasha) [#32328](#32328) - upgrade to libuv 1.34.2 (cjihrig) [#31477](#31477) - n-api: - add napi\_get\_all\_property\_names (himself65) [#30006](#30006) - add APIs for per-instance state management (Gabriel Schulhof) [#28682](#28682) - turn NAPI\_CALL\_INTO\_MODULE into a function (Anna Henningsen) [#26128](#26128) - tls: - expose keylog event on TLSSocket (Alba Mendez) [#27654](#27654) - support TLS min/max protocol defaults in CLI (Sam Roberts) [#27946](#27946) - url: handle quasi-WHATWG URLs in urlToOptions() (cjihrig) [#26226](#26226) PR-URL: #31984
BethGriggs added a commit that referenced this pull request Apr 3, 2020
@BethGriggs
2020-03-26, Version 10.20.0 'Dubnium' (LTS)
997dbf1
Notable changes: - buffer: add{read|write}Big\[U\]Int64{BE|LE} methods (garygsc) [#19691](#19691) - build: macOS package notarization (Rod Vagg) [#31459](#31459) - deps: - update npm to 6.14.3 (Myles Borins) [#32368](#32368) - upgrade openssl sources to 1.1.1e (Hassaan Pasha) [#32328](#32328) - upgrade to libuv 1.34.2 (cjihrig) [#31477](#31477) - n-api: - add napi\_get\_all\_property\_names (himself65) [#30006](#30006) - add APIs for per-instance state management (Gabriel Schulhof) [#28682](#28682) - turn NAPI\_CALL\_INTO\_MODULE into a function (Anna Henningsen) [#26128](#26128) - tls: - expose keylog event on TLSSocket (Alba Mendez) [#27654](#27654) - support TLS min/max protocol defaults in CLI (Sam Roberts) [#27946](#27946) - url: handle quasi-WHATWG URLs in urlToOptions() (cjihrig) [#26226](#26226) PR-URL: #31984
BethGriggs added a commit that referenced this pull request Apr 6, 2020
@BethGriggs
2020-04-07, Version 10.20.0 'Dubnium' (LTS)
0326fc1
Notable changes: - buffer: add{read|write}Big\[U\]Int64{BE|LE} methods (garygsc) [#19691](#19691) - build: macOS package notarization (Rod Vagg) [#31459](#31459) - deps: - update npm to 6.14.3 (Myles Borins) [#32368](#32368) - upgrade openssl sources to 1.1.1e (Hassaan Pasha) [#32328](#32328) - upgrade to libuv 1.34.2 (cjihrig) [#31477](#31477) - n-api: - add napi\_get\_all\_property\_names (himself65) [#30006](#30006) - add APIs for per-instance state management (Gabriel Schulhof) [#28682](#28682) - define release 6 [#32058](#32058) - turn NAPI\_CALL\_INTO\_MODULE into a function (Anna Henningsen) [#26128](#26128) - tls: - expose keylog event on TLSSocket (Alba Mendez) [#27654](#27654) - support TLS min/max protocol defaults in CLI (Sam Roberts) [#27946](#27946) - url: handle quasi-WHATWG URLs in urlToOptions() (cjihrig) [#26226](#26226) PR-URL: #31984
BethGriggs added a commit that referenced this pull request Apr 7, 2020
@BethGriggs
2020-04-07, Version 10.20.0 'Dubnium' (LTS)
d5f87c5
macOS package notarization and a change in builder configuration The macOS binaries for this release, and future 10.x releases, are now being compiled on macOS 10.15 (Catalina) with Xcode 11 to support package notarization, a requirement for installing .pkg files on macOS 10.15 and later. Previous builds of Node.js 10.x were compiled on macOS 10.7 (Lion). As binaries are still being compiled to support a minimum of macOS 10.7 (Lion) we do not anticipate this having a negative impact on Node.js 10.x users with older versions of macOS. Notable changes: - buffer: add{read|write}Big\[U\]Int64{BE|LE} methods (garygsc) [#19691](#19691) - build: macOS package notarization (Rod Vagg) [#31459](#31459) - deps: - update npm to 6.14.3 (Myles Borins) [#32368](#32368) - upgrade openssl sources to 1.1.1e (Hassaan Pasha) [#32328](#32328) - upgrade to libuv 1.34.2 (cjihrig) [#31477](#31477) - n-api: - add napi\_get\_all\_property\_names (himself65) [#30006](#30006) - add APIs for per-instance state management (Gabriel Schulhof) [#28682](#28682) - define release 6 [#32058](#32058) - turn NAPI\_CALL\_INTO\_MODULE into a function (Anna Henningsen) [#26128](#26128) - tls: - expose keylog event on TLSSocket (Alba Mendez) [#27654](#27654) - support TLS min/max protocol defaults in CLI (Sam Roberts) [#27946](#27946) - url: handle quasi-WHATWG URLs in urlToOptions() (cjihrig) [#26226](#26226) PR-URL: #31984
BethGriggs added a commit that referenced this pull request Apr 7, 2020
@BethGriggs
2020-04-07, Version 10.20.0 'Dubnium' (LTS)
b6d4334
macOS package notarization and a change in builder configuration The macOS binaries for this release, and future 10.x releases, are now being compiled on macOS 10.15 (Catalina) with Xcode 11 to support package notarization, a requirement for installing .pkg files on macOS 10.15 and later. Previous builds of Node.js 10.x were compiled on macOS 10.10 (Yosemite) with a minimum deployment target of macOS 10.7 (Lion). As binaries are still being compiled to support a minimum of macOS 10.7 (Lion) we do not anticipate this having a negative impact on Node.js 10.x users with older versions of macOS. Notable changes: - buffer: add{read|write}Big\[U\]Int64{BE|LE} methods (garygsc) [#19691](#19691) - build: macOS package notarization (Rod Vagg) [#31459](#31459) - deps: - update npm to 6.14.3 (Myles Borins) [#32368](#32368) - upgrade openssl sources to 1.1.1e (Hassaan Pasha) [#32328](#32328) - upgrade to libuv 1.34.2 (cjihrig) [#31477](#31477) - n-api: - add napi\_get\_all\_property\_names (himself65) [#30006](#30006) - add APIs for per-instance state management (Gabriel Schulhof) [#28682](#28682) - define release 6 [#32058](#32058) - turn NAPI\_CALL\_INTO\_MODULE into a function (Anna Henningsen) [#26128](#26128) - tls: - expose keylog event on TLSSocket (Alba Mendez) [#27654](#27654) - support TLS min/max protocol defaults in CLI (Sam Roberts) [#27946](#27946) - url: handle quasi-WHATWG URLs in urlToOptions() (cjihrig) [#26226](#26226) PR-URL: #31984
BethGriggs added a commit that referenced this pull request Apr 8, 2020
@BethGriggs
2020-04-08, Version 10.20.0 'Dubnium' (LTS)
246eede
macOS package notarization and a change in builder configuration The macOS binaries for this release, and future 10.x releases, are now being compiled on macOS 10.15 (Catalina) with Xcode 11 to support package notarization, a requirement for installing .pkg files on macOS 10.15 and later. Previous builds of Node.js 10.x were compiled on macOS 10.10 (Yosemite) with a minimum deployment target of macOS 10.7 (Lion). As binaries are still being compiled to support a minimum of macOS 10.7 (Lion) we do not anticipate this having a negative impact on Node.js 10.x users with older versions of macOS. Notable changes: - buffer: add{read|write}Big\[U\]Int64{BE|LE} methods (garygsc) [#19691](#19691) - build: macOS package notarization (Rod Vagg) [#31459](#31459) - deps: - update npm to 6.14.3 (Myles Borins) [#32368](#32368) - upgrade openssl sources to 1.1.1e (Hassaan Pasha) [#32328](#32328) - upgrade to libuv 1.34.2 (cjihrig) [#31477](#31477) - n-api: - add napi\_get\_all\_property\_names (himself65) [#30006](#30006) - add APIs for per-instance state management (Gabriel Schulhof) [#28682](#28682) - define release 6 [#32058](#32058) - turn NAPI\_CALL\_INTO\_MODULE into a function (Anna Henningsen) [#26128](#26128) - tls: - expose keylog event on TLSSocket (Alba Mendez) [#27654](#27654) - support TLS min/max protocol defaults in CLI (Sam Roberts) [#27946](#27946) - url: handle quasi-WHATWG URLs in urlToOptions() (cjihrig) [#26226](#26226) PR-URL: #31984
BethGriggs added a commit that referenced this pull request Apr 8, 2020
@BethGriggs
2020-04-08, Version 10.20.0 'Dubnium' (LTS)
9b46e3f
macOS package notarization and a change in builder configuration The macOS binaries for this release, and future 10.x releases, are now being compiled on macOS 10.15 (Catalina) with Xcode 11 to support package notarization, a requirement for installing .pkg files on macOS 10.15 and later. Previous builds of Node.js 10.x were compiled on macOS 10.10 (Yosemite) with a minimum deployment target of macOS 10.7 (Lion). As binaries are still being compiled to support a minimum of macOS 10.7 (Lion) we do not anticipate this having a negative impact on Node.js 10.x users with older versions of macOS. Notable changes: - buffer: add{read|write}Big\[U\]Int64{BE|LE} methods (garygsc) [#19691](#19691) - build: macOS package notarization (Rod Vagg) [#31459](#31459) - deps: - update npm to 6.14.3 (Myles Borins) [#32368](#32368) - upgrade openssl sources to 1.1.1e (Hassaan Pasha) [#32328](#32328) - upgrade to libuv 1.34.2 (cjihrig) [#31477](#31477) - n-api: - add napi\_get\_all\_property\_names (himself65) [#30006](#30006) - add APIs for per-instance state management (Gabriel Schulhof) [#28682](#28682) - define release 6 [#32058](#32058) - turn NAPI\_CALL\_INTO\_MODULE into a function (Anna Henningsen) [#26128](#26128) - tls: - expose keylog event on TLSSocket (Alba Mendez) [#27654](#27654) - support TLS min/max protocol defaults in CLI (Sam Roberts) [#27946](#27946) - url: handle quasi-WHATWG URLs in urlToOptions() (cjihrig) [#26226](#26226) PR-URL: #31984
BethGriggs added a commit that referenced this pull request Apr 14, 2020
@BethGriggs
2020-04-08, Version 10.20.0 'Dubnium' (LTS)
8d8095f
macOS package notarization and a change in builder configuration The macOS binaries for this release, and future 10.x releases, are now being compiled on macOS 10.15 (Catalina) with Xcode 11 to support package notarization, a requirement for installing .pkg files on macOS 10.15 and later. Previous builds of Node.js 10.x were compiled on macOS 10.10 (Yosemite) with a minimum deployment target of macOS 10.7 (Lion). As binaries are still being compiled to support a minimum of macOS 10.7 (Lion) we do not anticipate this having a negative impact on Node.js 10.x users with older versions of macOS. Notable changes: - buffer: add{read|write}Big\[U\]Int64{BE|LE} methods (garygsc) [#19691](#19691) - build: macOS package notarization (Rod Vagg) [#31459](#31459) - deps: - update npm to 6.14.3 (Myles Borins) [#32368](#32368) - upgrade openssl sources to 1.1.1e (Hassaan Pasha) [#32328](#32328) - upgrade to libuv 1.34.2 (cjihrig) [#31477](#31477) - n-api: - add napi\_get\_all\_property\_names (himself65) [#30006](#30006) - add APIs for per-instance state management (Gabriel Schulhof) [#28682](#28682) - define release 6 [#32058](#32058) - turn NAPI\_CALL\_INTO\_MODULE into a function (Anna Henningsen) [#26128](#26128) - tls: - expose keylog event on TLSSocket (Alba Mendez) [#27654](#27654) - support TLS min/max protocol defaults in CLI (Sam Roberts) [#27946](#27946) - url: handle quasi-WHATWG URLs in urlToOptions() (cjihrig) [#26226](#26226) PR-URL: #31984
@BethGriggsBethGriggs mentioned this pull request Feb 17, 2022
Closed
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@richardlaurichardlaurichardlau left review comments

@bnoordhuisbnoordhuisbnoordhuis approved these changes

@addaleaxaddaleaxaddaleax approved these changes

@codebyterecodebyterecodebytere approved these changes

@BethGriggsBethGriggsBethGriggs approved these changes

Assignees

No one assigned

Labels

semver-minorPRs that contain new features and should be released in the next minor version.tlsIssues and PRs related to the tls subsystem.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

9 participants

@sam-github@nodejs-github-bot@BethGriggs@richardlau@bnoordhuis@addaleax@codebytere@mscdex@BridgeAR