http: fix socketOnWrap edge cases#27968
Closed
+37 −35
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Properly handle prependListener wrapping on http server socket, in addition to on and addListener.
Collaborator
nodejs-github-bot commented May 30, 2019
ZYSzys approved these changes May 30, 2019
| socket.addListener=socket.on; | ||
| socket.on=generateSocketListenerWrapper('on'); | ||
| socket.addListener=generateSocketListenerWrapper('addListener'); | ||
| socket.prependListener=generateSocketListenerWrapper('prependListener'); |
Member
There was a problem hiding this comment.
Maybe also add addListener and prependListener to the comment for clarify ?
Collaborator
nodejs-github-bot commented May 31, 2019
lpinca approved these changes May 31, 2019
Trott approved these changes Jun 1, 2019
Member
Trott commented Jun 2, 2019
Landed in 58b1fe7 |
Trott pushed a commit to Trott/io.js that referenced this pull request Jun 2, 2019
Properly handle prependListener wrapping on http server socket, in addition to on and addListener. PR-URL: nodejs#27968 Reviewed-By: Yongsheng Zhang <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Rich Trott <[email protected]>
targos pushed a commit that referenced this pull request Jun 3, 2019
Properly handle prependListener wrapping on http server socket, in addition to on and addListener. PR-URL: #27968 Reviewed-By: Yongsheng Zhang <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Rich Trott <[email protected]>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Properly handle
prependListenerwrapping on http server socket, in addition toonandaddListener. (A commit was made that was supposed to fix this last month but hadn't actually done so.)Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes