test: rename test-performance to test-perf-hooks#27969
Closed
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Rename test-performance to test-perf-hooks to better match its function Refs: nodejs#27884 (comment)
Member
Trott commented May 30, 2019
LGTM but let's ping @nodejs/performance @jasnell just in case.... |
ContributorAuthor
ryzokuken commented May 30, 2019
Sure. |
addaleax approved these changes May 30, 2019
cjihrig approved these changes May 30, 2019
This comment has been minimized.
This comment has been minimized.
Collaborator
nodejs-github-bot commented May 30, 2019
ZYSzys approved these changes May 30, 2019
ZYSzys added author ready ContributorAuthor
ryzokuken commented May 30, 2019
trivikr approved these changes May 31, 2019
Contributor
refack commented May 31, 2019
Reminder to rename #25903 |
Collaborator
nodejs-github-bot commented Jun 1, 2019
ContributorAuthor
ryzokuken commented Jun 1, 2019
Passed! Landing this. |
ContributorAuthor
ryzokuken commented Jun 1, 2019
Landed in 389804e 🎉 |
ryzokuken added a commit that referenced this pull request Jun 1, 2019
Rename test-performance to test-perf-hooks to better match its function Refs: #27884 (comment) PR-URL: #27969 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Yongsheng Zhang <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]>
targos pushed a commit that referenced this pull request Jun 1, 2019
Rename test-performance to test-perf-hooks to better match its function Refs: #27884 (comment) PR-URL: #27969 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Yongsheng Zhang <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rename test-performance to test-perf-hooks to better match its function
Refs: #27884 (comment)
/cc @Trott
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes