src: do not use pointer for loop in node_watchdog#28020
Closed
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
addaleax added c++ 
richardlau approved these changes Jun 2, 2019
cjihrig approved these changes Jun 2, 2019
bnoordhuis approved these changes Jun 3, 2019
Member
bnoordhuis left a comment
bnoordhuis left a comment There was a problem hiding this comment.
LGTM but is there a reason loop_ can't be an embedded uv_loop_t rather than a pointer-to-uv_loop_t?
BridgeAR added the author ready 
This comment has been minimized.
This comment has been minimized.
addaleax changed the title 
MemberAuthor
addaleax commented Jun 9, 2019
@bnoordhuis Hm yeah, don’t know why I didn’t do that 😄 Updated! |
addaleaxforce-pushed the watchdog-unique-ptr branch from 31a0455 to 9a6151fCompare This comment has been minimized.
This comment has been minimized.
richardlau approved these changes Jun 9, 2019
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
jasnell approved these changes Jun 10, 2019
This comment has been minimized.
This comment has been minimized.
Member
Trott commented Jun 13, 2019
Trott approved these changes Jun 13, 2019
Member
Trott commented Jun 13, 2019
Landed in 25399e4 |
Trott pushed a commit to Trott/io.js that referenced this pull request Jun 13, 2019
PR-URL: nodejs#28020 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Rich Trott <[email protected]>
BridgeAR pushed a commit that referenced this pull request Jun 17, 2019
PR-URL: #28020 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Rich Trott <[email protected]>
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes