Skip to content

src: use RAII in setgroups implementation#28022

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
addaleax wants to merge 1 commit into from
Closed

src: use RAII in setgroups implementation #28022

addaleax wants to merge 1 commit into from

Conversation

@addaleax
Copy link
Member

@addaleaxaddaleax commented Jun 2, 2019

Prefer MaybeStackBuffer over manual memory management.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@addaleax
src: use RAII in setgroups implementation
f388d33
Prefer `MaybeStackBuffer` over manual memory management.
@addaleaxaddaleax added c++ Issues and PRs that require attention from people who are familiar with C++. lib / src Issues and PRs related to general changes in the lib or src directory. labels Jun 2, 2019
@BridgeARBridgeAR added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Jun 4, 2019
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Jun 4, 2019

CI: https://ci.nodejs.org/job/node-test-pull-request/23609/

@Trott
Copy link
Member

Trott commented Jun 6, 2019

Landed in a8277dd

@TrottTrott closed this Jun 6, 2019
Trott pushed a commit to Trott/io.js that referenced this pull request Jun 6, 2019
@addaleax@Trott
src: use RAII in setgroups implementation
a8277dd
Prefer `MaybeStackBuffer` over manual memory management. PR-URL: nodejs#28022 Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Rich Trott <[email protected]>
BridgeAR pushed a commit that referenced this pull request Jun 17, 2019
@addaleax@BridgeAR
src: use RAII in setgroups implementation
95ee3b5
Prefer `MaybeStackBuffer` over manual memory management. PR-URL: #28022 Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Rich Trott <[email protected]>
@BridgeARBridgeAR mentioned this pull request Jun 17, 2019
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bnoordhuisbnoordhuisbnoordhuis approved these changes

@TrottTrottTrott approved these changes

@cjihrigcjihrigcjihrig approved these changes

Assignees

No one assigned

Labels

author readyPRs that have at least one approval, no pending requests for changes, and a CI started.c++Issues and PRs that require attention from people who are familiar with C++.lib / srcIssues and PRs related to general changes in the lib or src directory.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@addaleax@nodejs-github-bot@Trott@bnoordhuis@cjihrig@BridgeAR