src: fix unused private field warning#28036
Closed
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
danbev approved these changes Jun 3, 2019
targos approved these changes Jun 3, 2019
Collaborator
nodejs-github-bot commented Jun 3, 2019
ZYSzys approved these changes Jun 3, 2019
ZYSzys added author ready Collaborator
CI: https://ci.nodejs.org/job/node-test-pull-request/23589/ EDIT(cjihrig): CI was yellow. |
cjihrig changed the title 
sam-github approved these changes Jun 3, 2019
Contributor
sam-github left a comment
sam-github left a comment There was a problem hiding this comment.
LGTM. Is the explicit related to the _env fix?
ContributorAuthor
cjihrig commented Jun 3, 2019
Yes. After removing the unused constructor argument, you get the following warning: Zero-parameter constructors should not be marked explicit. |
Contributor
danbev commented Jun 4, 2019
Could we fast track this? If you agree please give a 👍 and if you disagree please remove the |
BridgeAR approved these changes Jun 4, 2019
Contributor
danbev commented Jun 5, 2019
Landed in 2c76874. |
danbev pushed a commit that referenced this pull request Jun 5, 2019
PR-URL: #28036 Reviewed-By: Daniel Bevenius <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Yongsheng Zhang <[email protected]> Reviewed-By: Sam Roberts <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]>
BridgeAR pushed a commit that referenced this pull request Jun 17, 2019
PR-URL: #28036 Reviewed-By: Daniel Bevenius <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Yongsheng Zhang <[email protected]> Reviewed-By: Sam Roberts <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]>
Merged
codebytere added a commit to electron/node that referenced this pull request Jul 3, 2019
Removed in nodejs/node#28036; this patch can be removed when we update to v12.5.0
codebytere added a commit to electron/node that referenced this pull request Jul 3, 2019
Removed in nodejs/node#28036; this patch can be removed when we update to v12.5.0
MarshallOfSound pushed a commit to electron/node that referenced this pull request Jul 4, 2019
Removed in nodejs/node#28036; this patch can be removed when we update to v12.5.0
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes the following warning (and subsequent warnings that occurred from fixing the original warning):
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes