Skip to content

test: make sure vtable is generated in addon test with LTO#28057

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
addaleax wants to merge 1 commit into from
Closed

test: make sure vtable is generated in addon test with LTO #28057

addaleax wants to merge 1 commit into from

Conversation

@addaleax
Copy link
Member

@addaleaxaddaleax commented Jun 4, 2019

Fixes: #28026

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines

@addaleaxaddaleax mentioned this pull request Jun 4, 2019
Closed
4 tasks
@addaleaxaddaleax added addons Issues and PRs related to native addons. c++ Issues and PRs that require attention from people who are familiar with C++. test Issues and PRs related to the tests. labels Jun 4, 2019
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Jun 4, 2019

CI: https://ci.nodejs.org/job/node-test-pull-request/23614/

@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Jun 4, 2019

CI: https://ci.nodejs.org/job/node-test-pull-request/23619/

@richardlaurichardlau added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Jun 4, 2019
@danbev
Copy link
Contributor

danbev commented Jun 7, 2019

Landed in b31bfad.

@danbevdanbev closed this Jun 7, 2019
danbev pushed a commit that referenced this pull request Jun 7, 2019
@addaleax@danbev
test: make sure vtable is generated in addon test with LTO
b31bfad
PR-URL: #28057Fixes: #28026 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Richard Lau <[email protected]>
BridgeAR pushed a commit that referenced this pull request Jun 17, 2019
@addaleax@BridgeAR
test: make sure vtable is generated in addon test with LTO
87e977a
PR-URL: #28057Fixes: #28026 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Richard Lau <[email protected]>
@BridgeARBridgeAR mentioned this pull request Jun 17, 2019
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cjihrigcjihrigcjihrig approved these changes

@richardlaurichardlaurichardlau approved these changes

Assignees

No one assigned

Labels

addonsIssues and PRs related to native addons.author readyPRs that have at least one approval, no pending requests for changes, and a CI started.c++Issues and PRs that require attention from people who are familiar with C++.testIssues and PRs related to the tests.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

test: abort/test-addon-uv-handle-leak failure when LTO is enabled

5 participants

@addaleax@nodejs-github-bot@danbev@cjihrig@richardlau