crypto: add debug info to client emit secureConnect#28067
Closed
+4 −2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
danbevforce-pushed the _tls_wrap_debug_statements branch from e815b0c to b047e57Compare
cjihrig approved these changes Jun 5, 2019
richardlau approved these changes Jun 5, 2019
Member
richardlau left a comment
richardlau left a comment There was a problem hiding this comment.
Commit message contains a typo: NODE_DEBUG='tsl' -> NODE_DEBUG='tls'.
Currently, when debugging a TLS connection there might be multiple debug statements 'client emit secureConnect' for the 'secureConnect` event when using NODE_DEBUG='tls'. While it is possible to step through this with a debugger that is not always the fastest/easiest to do if debugging remote code. This commit adds some additional information to the debug statements to make it easier to distinguish where the debug statements are coming from.
ContributorAuthor
danbev commented Jun 5, 2019
Thanks, I've updated the commit message now. |
danbevforce-pushed the _tls_wrap_debug_statements branch from b047e57 to 1a6efb6Compare
sam-github approved these changes Jun 5, 2019
Collaborator
nodejs-github-bot commented Jun 5, 2019
ZYSzys approved these changes Jun 5, 2019
trivikr approved these changes Jun 5, 2019
Trott approved these changes Jun 6, 2019
Collaborator
nodejs-github-bot commented Jun 6, 2019
ContributorAuthor
danbev commented Jun 10, 2019
Landed in 5bad514. |
danbev added a commit that referenced this pull request Jun 10, 2019
Currently, when debugging a TLS connection there might be multiple debug statements 'client emit secureConnect' for the 'secureConnect` event when using NODE_DEBUG='tls'. While it is possible to step through this with a debugger that is not always the fastest/easiest to do if debugging remote code. This commit adds some additional information to the debug statements to make it easier to distinguish where the debug statements are coming from. PR-URL: #28067 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Sam Roberts <[email protected]> Reviewed-By: Yongsheng Zhang <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]> Reviewed-By: Rich Trott <[email protected]>
BridgeAR pushed a commit that referenced this pull request Jun 17, 2019
Currently, when debugging a TLS connection there might be multiple debug statements 'client emit secureConnect' for the 'secureConnect` event when using NODE_DEBUG='tls'. While it is possible to step through this with a debugger that is not always the fastest/easiest to do if debugging remote code. This commit adds some additional information to the debug statements to make it easier to distinguish where the debug statements are coming from. PR-URL: #28067 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Sam Roberts <[email protected]> Reviewed-By: Yongsheng Zhang <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]> Reviewed-By: Rich Trott <[email protected]>
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, when debugging a TLS connection there might be multiple debug
statements
client emit secureConnectfor the 'secureConnect' eventwhen using
NODE_DEBUG='tls'. While it is possible to step through thiswith a debugger that is not always the fastest/easiest to do if debugging
remote code.
This commit adds some additional information to the debug statements to
make it easier to distinguish where the debug statements are coming
from.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes