Fix configure script to work with Apple Clang 11#28071
Merged
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
nodejs-github-bot added the build 
bnoordhuis approved these changes Jun 5, 2019
Uh oh!
There was an error while loading. Please reload this page.
lpinca approved these changes Jun 5, 2019
richardlau approved these changes Jun 5, 2019
Collaborator
nodejs-github-bot commented Jun 11, 2019
Member
lpinca commented Jun 11, 2019
@saagarjha can you please fix the commit title? |
ContributorAuthor
saagarjha commented Jun 11, 2019
Fixed, thanks. |
PR-URL: nodejs#28071 Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Refael Ackermann (רפאל פלחי) <[email protected]>
refack added the python BridgeAR pushed a commit that referenced this pull request Jun 17, 2019
PR-URL: #28071 Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Refael Ackermann (רפאל פלחי) <[email protected]>
Merged
Member
AshCripps commented Nov 12, 2019
I suggest this gets backported to v10.x as without this change im unable to build v10 on catalina with current xcode versions. @BethGriggs @nodejs/lts |
Contributor
@nodejs/lts Doesn't affect our CI, but catalina users won't be able to build v10.x without it. Picks clean onto v10.x-staging. |
BethGriggs pushed a commit that referenced this pull request Nov 19, 2019
PR-URL: #28071 Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Refael Ackermann (רפאל פלחי) <[email protected]>
Closed
MylesBorins pushed a commit that referenced this pull request Dec 17, 2019
PR-URL: #28071 Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Refael Ackermann (רפאל פלחי) <[email protected]>
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesXcode 11's clang doesn't match our regex:
I've updated the regex in the configure script so that it will try to match the newer one if the old one fails.