doc: remove superfluous filenaming convention#28089
Closed
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
It is debatable whether "it is considered good style" in Node.js to use hypens or underscores to separate words in file names. Node.js has little to say about that. Remove that material as it is superfluous.
targos approved these changes Jun 6, 2019
MemberAuthor
Trott commented Jun 6, 2019
Trott added author ready 
BethGriggs approved these changes Jun 6, 2019
apapirovski approved these changes Jun 6, 2019
lpinca approved these changes Jun 6, 2019
trivikr approved these changes Jun 6, 2019
antsmartian approved these changes Jun 8, 2019
cjihrig approved these changes Jun 8, 2019
MemberAuthor
Trott commented Jun 9, 2019
Landed in cb9232d |
Trott added a commit to Trott/io.js that referenced this pull request Jun 9, 2019
It is debatable whether "it is considered good style" in Node.js to use hypens or underscores to separate words in file names. Node.js has little to say about that. Remove that material as it is superfluous. PR-URL: nodejs#28089 Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Beth Griggs <[email protected]> Reviewed-By: Anatoli Papirovski <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]> Reviewed-By: Anto Aravinth <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
BridgeAR pushed a commit that referenced this pull request Jun 17, 2019
It is debatable whether "it is considered good style" in Node.js to use hypens or underscores to separate words in file names. Node.js has little to say about that. Remove that material as it is superfluous. PR-URL: #28089 Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Beth Griggs <[email protected]> Reviewed-By: Anatoli Papirovski <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]> Reviewed-By: Anto Aravinth <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It is debatable whether "it is considered good style" in Node.js to use
hypens or underscores to separate words in file names. Node.js has
little to say about that. Remove that material as it is superfluous.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes