doc: clarify special schemes#28091
Merged
doc: clarify special schemes #28091
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Member
targos commented Jun 6, 2019
what about "defined as" ? |
Trottforce-pushed the considered-2-be branch 2 times, most recently from a1fc4e1 to 33583e6Compare
MemberAuthor
@targos How's this?: According to the WHATWG URL Standard, special protocol schemes include `ftp`, `file`, `gopher`, `http`, `https`, `ws`, and `wss`. |
Trott added doc 
targos approved these changes Jun 6, 2019
BridgeAR approved these changes Jun 6, 2019
cjihrig approved these changes Jun 6, 2019
MemberAuthor
Trott commented Jun 6, 2019
Trott added the author ready 
trivikr approved these changes Jun 6, 2019
TimothyGu approved these changes Jun 6, 2019
Uh oh!
There was an error while loading. Please reload this page.
MemberAuthor
Trott commented Jun 9, 2019
In url.md, describe "special" protocol schemes as "special" rather than "considered to be special". PR-URL: nodejs#28091 Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]> Reviewed-By: Tiancheng "Timothy" Gu <[email protected]>
MemberAuthor
Trott commented Jun 9, 2019
Landed in d71f05c |
BridgeAR pushed a commit that referenced this pull request Jun 17, 2019
In url.md, describe "special" protocol schemes as "special" rather than "considered to be special". PR-URL: #28091 Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]> Reviewed-By: Tiancheng "Timothy" Gu <[email protected]>
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In url.md, describe protocol schemes as "deemed special by the
[standard]" rather than "considered to be special by the [standard]".
The use of "considered to be" suggests that they might not really be.
While "deemed" is a synonym for the most part, it connotes less doubt.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes