deps: ignore deps/.cipd fetched by deps/v8/tools/node/fetch_deps.py#28095
+2 −0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
This may show up when building and running v8 tests locally with tools/make-v8.sh
Collaborator
nodejs-github-bot commented Jun 6, 2019
Sadly, an error occurred when I tried to trigger a build. :( |
nodejs-github-bot added the meta Collaborator
nodejs-github-bot commented Jun 6, 2019
MemberAuthor
joyeecheung commented Jun 6, 2019
@nodejs/build-files |
richardlau approved these changes Jun 6, 2019
cjihrig approved these changes Jun 6, 2019
Trott approved these changes Jun 6, 2019
refack approved these changes Jun 6, 2019
refack added the author ready Collaborator
nodejs-github-bot commented Jun 6, 2019
Member
Trott commented Jun 9, 2019
Landed in be721e8 |
Trott pushed a commit to Trott/io.js that referenced this pull request Jun 9, 2019
This may show up when building and running v8 tests locally with tools/make-v8.sh PR-URL: nodejs#28095 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Refael Ackermann (רפאל פלחי) <[email protected]>
BridgeAR pushed a commit that referenced this pull request Jun 17, 2019
This may show up when building and running v8 tests locally with tools/make-v8.sh PR-URL: #28095 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Refael Ackermann (רפאל פלחי) <[email protected]>
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This may show up when building and running v8 tests locally
with tools/make-v8.sh
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes