Skip to content

test: mark test-worker-debug flaky#28107

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
sam-github wants to merge 1 commit into from
Closed

test: mark test-worker-debug flaky #28107

sam-github wants to merge 1 commit into from

Conversation

@sam-github
Copy link
Contributor

@sam-githubsam-github commented Jun 6, 2019

See: #28106

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Jun 6, 2019

Sadly, an error occurred when I tried to trigger a build. :(

@nodejs-github-botnodejs-github-bot added the test Issues and PRs related to the tests. label Jun 6, 2019
@sam-githubsam-github added the fast-track PRs that do not need to wait for 48 hours to land. label Jun 6, 2019
@sam-github
Copy link
ContributorAuthor

sam-github commented Jun 6, 2019

Do flaky statuses get fast-tracked? If they should be, please upvote!

@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Jun 6, 2019

CI: https://ci.nodejs.org/job/node-test-pull-request/23667/

@sam-githubsam-github added windows Issues and PRs related to the Windows platform. worker Issues and PRs related to Worker support. labels Jun 6, 2019
@gireeshpunathilgireeshpunathil added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Jun 7, 2019
@Trott
Copy link
Member

Trott commented Jun 7, 2019

Looks like this happened in 65a5f7b already.

@TrottTrott closed this Jun 7, 2019
@sam-githubsam-github deleted the mark-test-worker-debug-flaky branch June 7, 2019 04:00
@kissofirekissofire mentioned this pull request Jul 22, 2022
Open
@wedataintelligencewedataintelligence mentioned this pull request Jul 22, 2022
Open
@ron-a20ron-a20 mentioned this pull request Jul 22, 2022
Open
@Dmarch28Dmarch28 mentioned this pull request Jul 22, 2022
Open
@aliceUnhinged613aliceUnhinged613 mentioned this pull request Jul 22, 2022
Open
@137717unity137717unity mentioned this pull request Jul 22, 2022
Open
@baby636baby636 mentioned this pull request Jul 22, 2022
Open
@molllyn1molllyn1 mentioned this pull request Jul 23, 2022
Open
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@TrottTrottTrott approved these changes

@richardlaurichardlaurichardlau approved these changes

@gireeshpunathilgireeshpunathilgireeshpunathil approved these changes

@trivikrtrivikrtrivikr approved these changes

Assignees

No one assigned

Labels

author readyPRs that have at least one approval, no pending requests for changes, and a CI started.fast-trackPRs that do not need to wait for 48 hours to land.testIssues and PRs related to the tests.windowsIssues and PRs related to the Windows platform.workerIssues and PRs related to Worker support.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@sam-github@nodejs-github-bot@Trott@richardlau@gireeshpunathil@trivikr