Skip to content

Conversation

@joyeecheung
Copy link
Member

@joyeecheungjoyeecheung commented Jun 9, 2019

In addition correct the comment about what it does.

This is produced by

mv test/parallel/test-child-process-execfilesync-maxBuffer.js test/parallel/test-child-process-execfilesync-maxbuf.js 

If you use https://github.com/nodejs/node/pull/28139/files?w=1 to view the diff you can see they aren't doing anything too different.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

In addition correct the comment about what it does.
@nodejs-github-bot
Copy link
Collaborator

Sadly, an error occurred when I tried to trigger a build. :(

@nodejs-github-botnodejs-github-bot added the test Issues and PRs related to the tests. label Jun 9, 2019
@nodejs-github-bot
Copy link
Collaborator

@Trott
Copy link
Member

Trott commented Jun 9, 2019

Micro-nit: Is maxBuffer perhaps the ever-so-slightly better file name part since it clearly reflects what's being tested? (Like, if someone is looking for maxBuffer tests, they might do a case-insensitive grep for filenames with maxBuffer and miss it if it's maxbuf instead?)

@addaleaxaddaleax added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Jun 9, 2019
@joyeecheung
Copy link
MemberAuthor

@Trott There is also test-child-process-spawnsync-maxbuf.js, and a few other child process tests that do all lower-cases...I guess we should leave that to a future PR to change all these?

pullbot pushed a commit to whtiehack/node that referenced this pull request Jun 12, 2019
In addition correct the comment about what it does. PR-URL: nodejs#28139 Reviewed-By: Yongsheng Zhang <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
@joyeecheung
Copy link
MemberAuthor

Landed in e0fa30f

BridgeAR pushed a commit that referenced this pull request Jun 17, 2019
In addition correct the comment about what it does. PR-URL: #28139 Reviewed-By: Yongsheng Zhang <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
@BridgeARBridgeAR mentioned this pull request Jun 17, 2019
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author readyPRs that have at least one approval, no pending requests for changes, and a CI started.testIssues and PRs related to the tests.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants

@joyeecheung@nodejs-github-bot@Trott@addaleax@lpinca@cjihrig@ZYSzys