http2: refactor ping + settings object lifetime management#28150
+111 −55
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Have clearer ownership relations between the `Http2Ping`, `Http2Settings` and `Http2Session` objects. Ping and Settings objects are now owned by the `Http2Session` instance, and deleted along with it, so neither type of object refers to the session after it is gone. In the case of `Http2Ping`s, that deletion is slightly delayed, so we explicitly reset its `session_` property. Fixes: nodejs#28088
Collaborator
Sadly, an error occurred when I tried to trigger a build. :( |
nodejs-github-bot added c++ 
addaleax added http2 Collaborator
nodejs-github-bot commented Jun 10, 2019
jasnell approved these changes Jun 10, 2019
addaleax added the author ready This comment has been minimized.
This comment has been minimized.
ryzokuken approved these changes Jun 10, 2019
This comment has been minimized.
This comment has been minimized.
Member
Trott commented Jun 13, 2019
| consthttp2=require('http2'); | ||
| constv8=require('v8'); | ||
| // Regression test for https://github.com/nodejs/node/issues/28088: |
Member
There was a problem hiding this comment.
Looks like the last : is redundant here.
MemberAuthor
There was a problem hiding this comment.
I think it makes sense, given that a short explanation of the issue follows?
Member
There was a problem hiding this comment.
Maybe add a space. I think the link is necessary too. but : will make IDEs link the wrong url (Include github code review).
Member
Trott commented Jun 13, 2019
CI: https://ci.nodejs.org/job/node-test-pull-request/23860/ (Failure was one of the test-cpu-prof* tests. Second one I've seen in the last 10 minutes. I'm still on Team Move-CPU-Profiling-Tests-To-Sequential!) |
Collaborator
nodejs-github-bot commented Jun 17, 2019
Collaborator
nodejs-github-bot commented Jun 17, 2019
Trott approved these changes Jun 17, 2019
Member
Trott commented Jun 17, 2019
Landed in 2a9f1ad |
Trott pushed a commit to Trott/io.js that referenced this pull request Jun 17, 2019
Have clearer ownership relations between the `Http2Ping`, `Http2Settings` and `Http2Session` objects. Ping and Settings objects are now owned by the `Http2Session` instance, and deleted along with it, so neither type of object refers to the session after it is gone. In the case of `Http2Ping`s, that deletion is slightly delayed, so we explicitly reset its `session_` property. Fixes: nodejs#28088 PR-URL: nodejs#28150 Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Ujjwal Sharma <[email protected]> Reviewed-By: Rich Trott <[email protected]>
targos pushed a commit that referenced this pull request Jul 2, 2019
Have clearer ownership relations between the `Http2Ping`, `Http2Settings` and `Http2Session` objects. Ping and Settings objects are now owned by the `Http2Session` instance, and deleted along with it, so neither type of object refers to the session after it is gone. In the case of `Http2Ping`s, that deletion is slightly delayed, so we explicitly reset its `session_` property. Fixes: #28088 PR-URL: #28150 Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Ujjwal Sharma <[email protected]> Reviewed-By: Rich Trott <[email protected]>
This was referenced Jul 3, 2019
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Have clearer ownership relations between the
Http2Ping,Http2SettingsandHttp2Sessionobjects.Ping and Settings objects are now owned by the
Http2Sessioninstance, and deleted along with it, so neither type of object
refers to the session after it is gone.
In the case of
Http2Pings, that deletion is slightly delayed,so we explicitly reset its
session_property.Fixes: #28088
@nodejs/http2
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes