build: guard test-doc recipe with node_use_openssl#28199
Closed
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Currently, when configuring --without-ssl the test-doc target fails with the following error: /node/test/common/index.js:707 const crashOnUnhandledRejection = (err) =>{throw err}; ^ Error [ERR_NO_CRYPTO]: Node.js is not compiled with OpenSSL crypto support at Object.assertCrypto (internal/util.js:97:11) at https.js:26:26 at NativeModule.compile (internal/bootstrap/loaders.js:300:5) ... at /node/tools/doc/versions.js:7:19 at new Promise (<anonymous>) at getUrl (/node/tools/doc/versions.js:6:10) Command: out/Release/node /node/test/doctool/test-doctool-html.js [00:02|% 100|+ 3|- 1]: Done make: *** [test-doc] Error 1 This commit guards the test-doc recipe to not run if node was configured without crypto support.
Collaborator
Sadly, an error occurred when I tried to trigger a build. :( |
nodejs-github-bot added the build Uh oh!
There was an error while loading. Please reload this page.
bnoordhuis approved these changes Jun 13, 2019
richardlau approved these changes Jun 13, 2019
jasnell approved these changes Jun 14, 2019
Trott approved these changes Jun 14, 2019
ContributorAuthor
danbev commented Jun 17, 2019
Landed in b456bbc. |
danbev added a commit that referenced this pull request Jun 17, 2019
Currently, when configuring --without-ssl the test-doc target fails with the following error: /node/test/common/index.js:707 const crashOnUnhandledRejection = (err) =>{throw err}; ^ Error [ERR_NO_CRYPTO]: Node.js is not compiled with OpenSSL crypto support at Object.assertCrypto (internal/util.js:97:11) at https.js:26:26 at NativeModule.compile (internal/bootstrap/loaders.js:300:5) ... at /node/tools/doc/versions.js:7:19 at new Promise (<anonymous>) at getUrl (/node/tools/doc/versions.js:6:10) Command: out/Release/node /node/test/doctool/test-doctool-html.js [00:02|% 100|+ 3|- 1]: Done make: *** [test-doc] Error 1 This commit guards the test-doc recipe to not run if node was configured without crypto support. PR-URL: #28199 Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Rich Trott <[email protected]>BridgeAR pushed a commit that referenced this pull request Jun 17, 2019
Currently, when configuring --without-ssl the test-doc target fails with the following error: /node/test/common/index.js:707 const crashOnUnhandledRejection = (err) =>{throw err}; ^ Error [ERR_NO_CRYPTO]: Node.js is not compiled with OpenSSL crypto support at Object.assertCrypto (internal/util.js:97:11) at https.js:26:26 at NativeModule.compile (internal/bootstrap/loaders.js:300:5) ... at /node/tools/doc/versions.js:7:19 at new Promise (<anonymous>) at getUrl (/node/tools/doc/versions.js:6:10) Command: out/Release/node /node/test/doctool/test-doctool-html.js [00:02|% 100|+ 3|- 1]: Done make: *** [test-doc] Error 1 This commit guards the test-doc recipe to not run if node was configured without crypto support. PR-URL: #28199 Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Rich Trott <[email protected]>
Merged
targos pushed a commit that referenced this pull request Jun 18, 2019
Currently, when configuring --without-ssl the test-doc target fails with the following error: /node/test/common/index.js:707 const crashOnUnhandledRejection = (err) =>{throw err}; ^ Error [ERR_NO_CRYPTO]: Node.js is not compiled with OpenSSL crypto support at Object.assertCrypto (internal/util.js:97:11) at https.js:26:26 at NativeModule.compile (internal/bootstrap/loaders.js:300:5) ... at /node/tools/doc/versions.js:7:19 at new Promise (<anonymous>) at getUrl (/node/tools/doc/versions.js:6:10) Command: out/Release/node /node/test/doctool/test-doctool-html.js [00:02|% 100|+ 3|- 1]: Done make: *** [test-doc] Error 1 This commit guards the test-doc recipe to not run if node was configured without crypto support. PR-URL: #28199 Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Rich Trott <[email protected]>
2 tasks
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, when configuring
--without-sslthetest-doctarget fails withthe following error:
This commit guards the test-doc recipe to not run if node was
configured without crypto support.
@nodejs/build, @nodejs/build-files
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes