doc: revise intro sentence for assert#28226
Merged
+2 −2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
nodejs-github-bot added assert 
MemberAuthor
Trott commented Jun 14, 2019
richardlau approved these changes Jun 14, 2019
Trott added the author ready 
BridgeAR approved these changes Jun 17, 2019
Member
BridgeAR left a comment
BridgeAR left a comment There was a problem hiding this comment.
LGTM but it seems like this needs a rebase.
BridgeAR removed the author ready MemberAuthor
Trott commented Jun 17, 2019
CI after rebase: https://ci.nodejs.org/job/node-test-pull-request-lite-pipeline/3687/ |
Trott added the author ready 
Simplify language, remove redundancy ("tests that can be used to test") and remove wordy passive voice ("that can be used to" replaced with "for"). PR-URL: nodejs#28226 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]>MemberAuthor
Trott commented Jun 17, 2019
Landed in db459e9 |
BridgeAR pushed a commit that referenced this pull request Jun 17, 2019
Simplify language, remove redundancy ("tests that can be used to test") and remove wordy passive voice ("that can be used to" replaced with "for"). PR-URL: #28226 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Merged
targos pushed a commit that referenced this pull request Jun 18, 2019
Simplify language, remove redundancy ("tests that can be used to test") and remove wordy passive voice ("that can be used to" replaced with "for"). PR-URL: #28226 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]>Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Simplify language, remove redundancy ("tests that can be used to
test") and remove wordy passive voice ("that can be used to" replaced
with "for").
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes