[v8.x] Update openssl 1.0.2s#28230
Closed
[v8.x] Update openssl 1.0.2s #28230
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Collaborator
Sadly, an error occurred when I tried to trigger a build. :( |
nodejs-github-bot added openssl 
sam-githubforce-pushed the update-openssl-1.0.2s-v8.x branch from 0884ff4 to 0a37768Compare
ContributorAuthor
sam-github commented Jun 14, 2019
There was a problem with how I upgraded, I messed up the opensslconf.h files, its now fixed. Also, the subject was wrong, sorry. This is NOT upgrading to openssl 1.1.1 (that would be totally incompatible), its just upgrading from openssl |
Collaborator
nodejs-github-bot commented Jun 18, 2019
ContributorAuthor
sam-github commented Jun 19, 2019
The notifications didn't get picked up by github, but the last CI passed. @nodejs/lts |
`x86masm.pl` was mistakenly using .486 instruction set, why `cpuid` (and perhaps others) are requiring .686 . Fixes: nodejs#589 PR-URL: nodejs#1389 Reviewed-By: Fedor Indutny <[email protected]> Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: Shigeki Ohtsu <[email protected]>
See https://mta.openssl.org/pipermail/openssl-dev/2015-February/000651.html iojs needs to stop using masm and move to nasm or yasm on Win32. Fixes: nodejs#589 PR-URL: nodejs#1389 Reviewed-By: Fedor Indutny <[email protected]> Reviewed-By: Ben Noordhuis <[email protected]>
Reapply b910613 . Fixes: nodejs#589 PR-URL: nodejs#1389 Reviewed-By: Fedor Indutny <[email protected]> Reviewed-By: Ben Noordhuis <[email protected]>
In openssl s_client on Windows, RAND_screen() is invoked to initialize random state but it takes several seconds in each connection. This added -no_rand_screen to openssl s_client on Windows to skip RAND_screen() and gets a better performance in the unit test of test-tls-server-verify. Do not enable this except to use in the unit test. Fixes: nodejs#1461 PR-URL: nodejs#1836 Reviewed-By: Ben Noordhuis <[email protected]>
sam-githubforce-pushed the update-openssl-1.0.2s-v8.x branch from 0a37768 to d3f13c1CompareCollaborator
nodejs-github-bot commented Sep 5, 2019
Collaborator
nodejs-github-bot commented Sep 19, 2019
Collaborator
nodejs-github-bot commented Sep 19, 2019
BethGriggs approved these changes Sep 19, 2019
Member
BethGriggs commented Sep 19, 2019
Landed on |
BethGriggs pushed a commit that referenced this pull request Sep 19, 2019
PR-URL: #28230 Reviewed-By: Beth Griggs <[email protected]>
BethGriggs pushed a commit that referenced this pull request Sep 19, 2019
PR-URL: #28230 Reviewed-By: Beth Griggs <[email protected]>
BethGriggs pushed a commit that referenced this pull request Sep 19, 2019
`x86masm.pl` was mistakenly using .486 instruction set, why `cpuid` (and perhaps others) are requiring .686 . Fixes: #589 Backport-PR-URL: #28230 PR-URL: #1389 Reviewed-By: Fedor Indutny <[email protected]> Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: Shigeki Ohtsu <[email protected]>
BethGriggs pushed a commit that referenced this pull request Sep 19, 2019
See https://mta.openssl.org/pipermail/openssl-dev/2015-February/000651.html iojs needs to stop using masm and move to nasm or yasm on Win32. Fixes: #589 Backport-PR-URL: #28230 PR-URL: #1389 Reviewed-By: Fedor Indutny <[email protected]> Reviewed-By: Ben Noordhuis <[email protected]>
BethGriggs pushed a commit that referenced this pull request Sep 19, 2019
Reapply b910613 . Fixes: #589 Backport-PR-URL: #28230 PR-URL: #1389 Reviewed-By: Fedor Indutny <[email protected]> Reviewed-By: Ben Noordhuis <[email protected]>
BethGriggs pushed a commit that referenced this pull request Sep 19, 2019
In openssl s_client on Windows, RAND_screen() is invoked to initialize random state but it takes several seconds in each connection. This added -no_rand_screen to openssl s_client on Windows to skip RAND_screen() and gets a better performance in the unit test of test-tls-server-verify. Do not enable this except to use in the unit test. Fixes: #1461 Backport-PR-URL: #28230 PR-URL: #1836 Reviewed-By: Ben Noordhuis <[email protected]>
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See nodejs/Release#448
I am still building locally, it will be a while, maybe CI is faster.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes