doc: deprecate finished#28679

ronag · 2019-07-14T12:04:45Z

Remove finished from docs. The naming and function is very confusing and misleading. What is finished is actually ended in the streams spec.

Refs: #28651

Checklist

make -j4 test (UNIX), or vcbuild test (Windows) passes
tests and/or benchmarks are included
documentation is changed or added
commit message follows commit guidelines

benjamingr

This needs to be docs-deprecated rather than removed from the docs altogether IMO

ronag · 2019-07-14T14:59:58Z

Not quite sure how to docs-deprecate... but I tried... feedback welcome

benjamingr · 2019-07-14T15:09:30Z

Does anyone have a strong opinion regarding how we should deprecate this? @mcollina maybe?

(no hurry)

addaleax · 2019-07-14T20:02:01Z

Does anyone have a strong opinion regarding how we should deprecate this?

I agree that documentation-only deprecating makes the most sense here.

doc/api/deprecations.md

doc/api/http.md

doc/api/http2.md

ronag · 2019-08-02T06:25:02Z

Blocked by #28934. Let's see what happens there first. It's relevant to the deprecation description.

ronag · 2019-08-05T09:36:17Z

fixed @ChALkeR

ronag · 2019-08-05T10:16:48Z

@Trott blocked by #28934

ronag · 2019-08-17T07:43:37Z

@Trott: this is no longer blocked, ping node/http?

ronag · 2019-11-20T19:15:09Z

@Trott: The doc linting error seems unrelated to this PR. Not sure what's going on there.

doc/api/deprecations.md

Co-Authored-By: Rich Trott <[email protected]>

ronag · 2019-11-20T22:50:01Z

@Trott: Linting pass

lundibundi · 2019-11-22T11:07:53Z

Lite-CI: https://ci.nodejs.org/job/node-test-pull-request-lite-pipeline/4082/

doc/api/deprecations.md

Co-Authored-By: Ruben Bridgewater <[email protected]>

BridgeAR · 2019-12-10T00:09:28Z

Lite-CI https://ci.nodejs.org/job/node-test-pull-request-lite-pipeline/4102/

PR-URL: #28679 Refs: #28651 Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]>

BridgeAR · 2019-12-10T00:33:54Z

Landed in c6ab3af 🎉

PR-URL: #28679 Refs: #28651 Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]>

This is a security release. This release includes a single commit, an update to npm to 6.13.4. For more details about the vulnerability please consult the npm blog: https://blog.npmjs.org/post/189618601100/binary-planting-with-the-npm-cli Notable Changes: * deps: - update npm to 6.13.4 #30904 - update uvwasi (Anna Henningsen) #30745 - upgrade to libuv 1.34.0 (Colin Ihrig) #30783 * doc: - docs deprecate http finished (Robert Nagy) #28679 * events: - add captureRejection option (Matteo Collina) #27867 * http: - add captureRejection support (Matteo Collina) #27867 - llhttp opt-in insecure HTTP header parsing (Sam Roberts) #30567 * http2: - implement capture rection for 'request' and 'stream' events (Matteo Collina) #27867 * net: - implement capture rejections for 'connection' event (Matteo Collina) #27867 * repl: - support previews by eager evaluating input (Ruben Bridgewater) #30811 * stream: - add support for captureRejection option (Matteo Collina) #27867 * tls: - implement capture rejections for 'secureConnection' event (Matteo Collina) #27867 - expose IETF name for current cipher suite (Sam Roberts) #30637 * worker: - add argv constructor option (legendecas) #30559 PR-URL: #30937

This is a security release. This release includes a single commit, an update to npm to 6.13.4. For more details about the vulnerability please consult the npm blog: https://blog.npmjs.org/post/189618601100/binary-planting-with-the-npm-cli Notable Changes: * deps: * update npm to 6.13.4 #30904 * update uvwasi (Anna Henningsen) #30745 * upgrade to libuv 1.34.0 (Colin Ihrig) #30783 * doc: * docs deprecate http finished (Robert Nagy) #28679 * events: * add captureRejection option (Matteo Collina) #27867 * http: * add captureRejection support (Matteo Collina) #27867 * llhttp opt-in insecure HTTP header parsing (Sam Roberts) #30567 * http2: * implement capture rection for 'request' and 'stream' events (Matteo Collina) #27867 * net: * implement capture rejections for 'connection' event (Matteo Collina) #27867 * repl: * support previews by eager evaluating input (Ruben Bridgewater) #30811 * stream: * add support for captureRejection option (Matteo Collina) #27867 * tls: * implement capture rejections for 'secureConnection' event (Matteo Collina) #27867 * expose IETF name for current cipher suite (Sam Roberts) #30637 * worker: * add argv constructor option (legendecas) #30559 PR-URL: #30937

This is a security release. For more details about the vulnerability please consult the npm blog: https://blog.npmjs.org/post/189618601100/binary-planting-with-the-npm-cli Notable Changes: * deps: * update npm to 6.13.4 #30904 * update uvwasi (Anna Henningsen) #30745 * upgrade to libuv 1.34.0 (Colin Ihrig) #30783 * doc: * docs deprecate http finished (Robert Nagy) #28679 * events: * add captureRejection option (Matteo Collina) #27867 * http: * add captureRejection support (Matteo Collina) #27867 * llhttp opt-in insecure HTTP header parsing (Sam Roberts) #30567 * http2: * implement capture rection for 'request' and 'stream' events (Matteo Collina) #27867 * net: * implement capture rejections for 'connection' event (Matteo Collina) #27867 * repl: * support previews by eager evaluating input (Ruben Bridgewater) #30811 * stream: * add support for captureRejection option (Matteo Collina) #27867 * tls: * implement capture rejections for 'secureConnection' event (Matteo Collina) #27867 * expose IETF name for current cipher suite (Sam Roberts) #30637 * worker: * add argv constructor option (legendecas) #30559 PR-URL: #30937

PR-URL: #28679 Refs: #28651 Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]>

nodejs-github-bot added the http Issues or PRs related to the http subsystem. label Jul 14, 2019

ronag force-pushed the deprecate-finished branch 4 times, most recently from 11a9c1a to 46e9301Compare July 14, 2019 12:43

benjamingr reviewed Jul 14, 2019
View reviewed changes

ronag force-pushed the deprecate-finished branch from 46e9301 to d967248Compare July 14, 2019 14:59

ronag changed the title ~~http: deprecate finished~~doc: deprecate finishedJul 14, 2019

ronag force-pushed the deprecate-finished branch 2 times, most recently from a97f9fc to cd143ecCompare July 14, 2019 21:19

Trott added the notable-change PRs with changes that should be highlighted in changelogs. label Jul 15, 2019

ChALkeR previously requested changes Jul 31, 2019
View reviewed changes

doc/api/deprecations.md Outdated Show resolvedHide resolved
doc/api/http.md Outdated Show resolvedHide resolved
doc/api/http.md Outdated Show resolvedHide resolved
doc/api/http2.md Outdated Show resolvedHide resolved

ronag force-pushed the deprecate-finished branch from cd143ec to b62d036Compare August 1, 2019 18:00

ronag mentioned this pull request Aug 5, 2019
http2: make compat finished match http/1 #24347
Closed
4 tasks

ronag force-pushed the deprecate-finished branch from b62d036 to 9d6fbd0Compare August 5, 2019 09:36

This was referenced Aug 6, 2019
stream: cleanup #29000
Closed
http: ClientRequest streamlike #29002
Closed

Trott added the blocked PRs that are blocked by other issues or PRs. label Aug 6, 2019

jasnell added deprecations Issues and PRs related to deprecations. semver-major PRs that contain breaking changes and should be released in the next major version. labels Aug 7, 2019

ronag force-pushed the deprecate-finished branch 3 times, most recently from aea31b3 to 9a0472aCompare August 17, 2019 07:42

Trott reviewed Nov 20, 2019
View reviewed changes

doc/api/deprecations.md Outdated Show resolvedHide resolved

ronagand others added 2 commits November 20, 2019 22:44

Update doc/api/deprecations.md
11337b6
Co-Authored-By: Rich Trott <[email protected]>

fixup: ref
dcd3724

ronag force-pushed the deprecate-finished branch from b159660 to dcd3724Compare November 20, 2019 22:21

Trott reviewed Dec 7, 2019
View reviewed changes

doc/api/deprecations.md Outdated Show resolvedHide resolved

ronag commented Dec 7, 2019
View reviewed changes

doc/api/deprecations.md Outdated Show resolvedHide resolved

Update doc/api/deprecations.md
476d612

Trott approved these changes Dec 7, 2019
View reviewed changes

BridgeAR reviewed Dec 9, 2019
View reviewed changes

doc/api/deprecations.md Outdated Show resolvedHide resolved

Update doc/api/deprecations.md
60c6119
Co-Authored-By: Ruben Bridgewater <[email protected]>

BridgeAR approved these changes Dec 10, 2019
View reviewed changes

BridgeAR pushed a commit that referenced this pull request Dec 10, 2019
doc: deprecate http finished
c6ab3af
PR-URL: #28679 Refs: #28651 Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]>

BridgeAR closed this Dec 10, 2019

targos pushed a commit that referenced this pull request Dec 10, 2019
doc: deprecate http finished
93ca4f4
PR-URL: #28679 Refs: #28651 Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]>

MylesBorins mentioned this pull request Dec 13, 2019
v13.4.0 proposal #30937
Merged

targos pushed a commit that referenced this pull request Jan 14, 2020
doc: deprecate http finished
ec514a6
PR-URL: #28679 Refs: #28651 Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]>

targos mentioned this pull request Jan 15, 2020
v12.15.0 release proposal #31368
Closed

BethGriggs pushed a commit that referenced this pull request Feb 6, 2020
doc: deprecate http finished
79521d3
PR-URL: #28679 Refs: #28651 Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]>

MylesBorins mentioned this pull request Feb 8, 2020
v12.16.0 proposal #31691
Merged

Uh oh!

doc: deprecate finished#28679

doc: deprecate finished #28679

Uh oh!

Conversation

ronag commented Jul 14, 2019

Checklist

Uh oh!

benjamingr left a comment

Choose a reason for hiding this comment

Uh oh!

ronag commented Jul 14, 2019• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

benjamingr commented Jul 14, 2019

Uh oh!

addaleax commented Jul 14, 2019

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

ronag commented Aug 2, 2019

Uh oh!

ronag commented Aug 5, 2019

Uh oh!

ronag commented Aug 5, 2019

Uh oh!

ronag commented Aug 17, 2019

Uh oh!

ronag commented Nov 20, 2019

Uh oh!

Uh oh!

ronag commented Nov 20, 2019• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

lundibundi commented Nov 22, 2019

Uh oh!

Uh oh!

Uh oh!

Uh oh!

BridgeAR commented Dec 10, 2019

Uh oh!

BridgeAR commented Dec 10, 2019

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

12 participants

ronag commented Jul 14, 2019•
edited
Loading

ronag commented Nov 20, 2019•
edited
Loading