Skip to content

http: refactor emit error#28696

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
ronag wants to merge 1 commit into from
Closed

http: refactor emit error #28696

ronag wants to merge 1 commit into from

Conversation

@ronag
Copy link
Member

@ronagronag commented Jul 15, 2019

A small cleanup.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@nodejs-github-botnodejs-github-bot added the http Issues or PRs related to the http subsystem. label Jul 15, 2019
lpinca
lpinca reviewed Jul 15, 2019
View reviewed changes
@ronagronagforce-pushed the http-refactor-emit-error branch from d9b0bce to c611d93CompareJuly 15, 2019 12:55
@ronagronag mentioned this pull request Jul 15, 2019
Closed
4 tasks
@ronag
Copy link
MemberAuthor

ronag commented Jul 15, 2019

Blocked by #20077

@trivikr
Copy link
Member

trivikr commented Jul 15, 2019

Code in PR #20077 landed, this PR can be rebased

@ronag
Copy link
MemberAuthor

ronag commented Jul 15, 2019

@trivikr rebased

@ronagronagforce-pushed the http-refactor-emit-error branch from c611d93 to 24aead5CompareJuly 15, 2019 20:35
@trivikr
Copy link
Member

trivikr commented Jul 15, 2019

I missed comment from @Trott
#20077 was reverted #20077 (comment)

@Trott
Copy link
Member

Trott commented Jul 17, 2019

Is this blocked on something still? #28683 perhaps?

@ronag
Copy link
MemberAuthor

ronag commented Jul 17, 2019

@Trott I don't think this is relevant anymore due to #28683.

@ronagronag closed this Jul 17, 2019
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jasnelljasnelljasnell approved these changes

@addaleaxaddaleaxaddaleax approved these changes

@lpincalpincalpinca approved these changes

@trivikrtrivikrtrivikr approved these changes

Assignees

No one assigned

Labels

httpIssues or PRs related to the http subsystem.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@ronag@trivikr@Trott@jasnell@addaleax@lpinca@nodejs-github-bot