[v10.x backport] test: remove util.inherits() usage#28795
Closed
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
PR-URL: #25245 Refs: #24755 Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Anna Henningsen <[email protected]>
Member
|
Member
lpinca commented Jul 21, 2019
Oh nvm it seems the change only affects tests. |
Collaborator
nodejs-github-bot commented Jul 23, 2019
Collaborator
nodejs-github-bot commented Jul 23, 2019
Collaborator
nodejs-github-bot commented Jul 24, 2019
This comment has been minimized.
This comment has been minimized.
Collaborator
BethGriggs approved these changes Jul 25, 2019
BethGriggs pushed a commit that referenced this pull request Jul 26, 2019
Backport-PR-URL: #28795 PR-URL: #25245 Refs: #24755 Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Anna Henningsen <[email protected]>
Member
BethGriggs commented Jul 26, 2019
Landed on |
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR-URL: #25245
Refs: #24755
Reviewed-By: Ruben Bridgewater [email protected]
Reviewed-By: Anna Henningsen [email protected]
Backport of #25245
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes