test: make cluster tests more time tolerant#2891
Closed
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Port nodejs/node-v0.x-archive@f3f4e28 to master, updating to guard changes for AIX as requestd
Member
Trott commented Sep 15, 2015
LGTM. (We don't have AIX in the current CI, do we?) |
Contributor
Fishrock123 commented Sep 15, 2015
LGTM |
mscdex added cluster 
MemberAuthor
mhdawson commented Sep 16, 2015
Thanks for the quick reviews. We don't have AIX in the CI yet. I'm working to try and get AIX machines but it seems that its not something that is commonly available to OS projects so I'm trying to figure out how we make one available. |
MemberAuthor
mhdawson commented Sep 16, 2015
MemberAuthor
mhdawson commented Sep 17, 2015
Some failures in CI but not related to test being changed and seen in other unrelated CI runs so not related to the change being made. Will land. |
mhdawson added a commit that referenced this pull request Sep 17, 2015
Port nodejs/node-v0.x-archive@f3f4e28 to master, updating to guard changes for AIX as requested PR-URL: #2891 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Jeremiah Senkpiel <[email protected]>
MemberAuthor
mhdawson commented Sep 17, 2015
Landed as 2853f98 |
mhdawson added a commit that referenced this pull request Sep 20, 2015
Port nodejs/node-v0.x-archive@f3f4e28 to master, updating to guard changes for AIX as requested PR-URL: #2891 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Jeremiah Senkpiel <[email protected]>
Contributor
MylesBorins commented Nov 16, 2015
landed in lts-v4.x-staging as 71b5d80 |
Contributor
ncopa commented Feb 3, 2016
This issue affects Alpine Linux (musl libc) also and not only AIX. |
3 tasks
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Port nodejs/node-v0.x-archive@f3f4e28
to master, updating to guard changes for AIX as requestd