fs: fix broken esm#28957
fs: fix broken esm #28957
Uh oh!
There was an error while loading. Please reload this page.
Conversation
nodejs-github-bot added the fs 
ronag commented Aug 4, 2019
@Trott: can I get a CITGM on this one? |
@benjamingr can you start a CITGM on this one? ping @Trott |
mcollina commented Aug 6, 2019
cc @jdalton wdyt? |
jdalton commented Aug 6, 2019
LGTM as a workaround until a fix can be published. |
BridgeAR commented Aug 6, 2019
@jdalton did your recent change in esm not fix the issue? |
BridgeAR left a comment
BridgeAR left a comment There was a problem hiding this comment.
LGTM as intermediate fix. This should definitely be removed as soon as possible though.
Uh oh!
There was an error while loading. Please reload this page.
Trott commented Aug 6, 2019
@mcollina Looks good to you as a temporary measure? |
nodejs-github-bot commented Aug 6, 2019
CITGM: https://ci.nodejs.org/view/Node.js-citgm/job/citgm-smoker/1923/ |
BridgeAR added the author ready 
| Object.setPrototypeOf(Stats.prototype,StatsBase.prototype); | ||
| Object.setPrototypeOf(Stats,StatsBase); | ||
| // HACK: Workaround for https://github.com/standard-things/esm/issues/821. |
There was a problem hiding this comment.
nit: period becomes part of link
| // HACK: Workaround for https://github.com/standard-things/esm/issues/821. | |
| // HACK: Workaround for https://github.com/standard-things/esm/issues/821 |
nodejs-github-bot commented Aug 6, 2019
Trott commented Aug 6, 2019
CITGM this PR: https://ci.nodejs.org/view/Node.js-citgm/job/citgm-smoker/1923/ CITGM against master: https://ci.nodejs.org/view/Node.js-citgm/job/citgm-smoker/1925/ |
CITGM master: 84 failures CITM this PR: 29 failures CI is green
Landing. |
Fix to unblock CITGM. See, standard-things/esm#821. PR-URL: nodejs#28957 Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]>
Trott commented Aug 7, 2019
(@joyeecheung If you have an issue with this, we can revert it, of course.) |
Trott commented Aug 7, 2019
Landed in 320402c |
joyeecheung commented Aug 7, 2019
Belated LGTM and thanks for the ping! |
targos commented Aug 19, 2019
Backport blocked by #21387 |
Fix to unblock CITGM. See, standard-things/esm#821. PR-URL: #28957 Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]>
9 participants
Tries to fix blocked CITGM. See, standard-things/esm#821.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes