doc: improve UV_THREADPOOL_SIZE description#29033
Closed
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
nodejs-github-bot added cli 
cjihrig approved these changes Aug 7, 2019
antsmartian approved these changes Aug 7, 2019
antsmartian added the author ready 
bnoordhuis approved these changes Aug 7, 2019
BethGriggs approved these changes Aug 7, 2019
jasnell approved these changes Aug 7, 2019
Trott approved these changes Aug 7, 2019
trivikr approved these changes Aug 8, 2019
Member
Trott commented Aug 8, 2019
lpinca approved these changes Aug 9, 2019
MemberAuthor
tniessen commented Aug 9, 2019
Landed in 885c644, thanks for reviewing! |
tniessen added a commit that referenced this pull request Aug 9, 2019
PR-URL: #29033 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Anto Aravinth <[email protected]> Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: Beth Griggs <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
targos pushed a commit that referenced this pull request Aug 19, 2019
PR-URL: #29033 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Anto Aravinth <[email protected]> Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: Beth Griggs <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
This was referenced Aug 20, 2019
tniessen removed the author ready Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
10 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
UV_THREADPOOL_SIZEdocumentation claims that only threecryptoAPIs use the thread pool, which is not true anymore. This commit lists all relevant APIs and rephrases it such that future API additions are included in the documentation.Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes