http: outgoing cork#29053
Closed
http: outgoing cork #29053
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
9 tasks
ronagforce-pushed the http-outgoing-cork branch 3 times, most recently from 961eefa to 0ddf57bCompare
MemberAuthor
ronag commented Aug 8, 2019
Not sure exactly how corking a http2 stream works. Would that cork other responses as well? Or does the multiplexing happen on a lower level? |
mscdex reviewed Aug 8, 2019
Uh oh!
There was an error while loading. Please reload this page.
ronagforce-pushed the http-outgoing-cork branch 3 times, most recently from 92fa16b to d54f0a5Compare
Member
jasnell commented Aug 22, 2019
multiplexing happens on the native layer. corking an Http2Stream has no impact on any other Http2Stream instances. |
ronagforce-pushed the http-outgoing-cork branch 3 times, most recently from 650eeab to c650a63Compare
addaleax reviewed Nov 4, 2019
Uh oh!
There was an error while loading. Please reload this page.
ronagforce-pushed the http-outgoing-cork branch from c650a63 to 796f541Compare
Collaborator
nodejs-github-bot commented Nov 4, 2019
MemberAuthor
ronag commented Nov 4, 2019
Sorry, there is a test failure. Right now I can't build node due to:
I'll fix this once I've figured out how to build Node again. |
MemberAuthor
ronag commented Nov 4, 2019
Member
addaleax commented Nov 5, 2019
ronagforce-pushed the http-outgoing-cork branch from 796f541 to 7290bf1CompareMemberAuthor
ronag commented Nov 6, 2019
rebased |
MemberAuthor
ronag commented Nov 11, 2019
@Trott failed on compile V8? |
Collaborator
nodejs-github-bot commented Nov 11, 2019
Member
Test failures in test-http-response-cork: NaN !== undefined at Server.<anonymous> (/home/iojs/build/workspace/node-test-commit-linux/nodes/alpine-latest-x64/test/parallel/test-http-response-cork.js:15:10) |
ronagforce-pushed the http-outgoing-cork branch from 7290bf1 to b5a611fCompareMemberAuthor
Hm, that was a minor bug in |
Collaborator
nodejs-github-bot commented Nov 12, 2019
Member
Trott commented Nov 12, 2019
@nodejs/http This could use more reviews. |
addaleax approved these changes Nov 13, 2019
Member
addaleax left a comment
addaleax left a comment There was a problem hiding this comment.
LGTM but I’d put the _stream_duplex.js changes in a separate commit (while landing)
addaleax added a commit that referenced this pull request Nov 13, 2019
PR-URL: #29053 Reviewed-By: Anna Henningsen <[email protected]>
addaleax pushed a commit that referenced this pull request Nov 13, 2019
PR-URL: #29053 Reviewed-By: Anna Henningsen <[email protected]>
Member
addaleax commented Nov 13, 2019
MylesBorins pushed a commit that referenced this pull request Nov 17, 2019
PR-URL: #29053 Reviewed-By: Anna Henningsen <[email protected]>
MylesBorins pushed a commit that referenced this pull request Nov 17, 2019
PR-URL: #29053 Reviewed-By: Anna Henningsen <[email protected]>
Merged
4 tasks
targos added the semver-minor targos pushed a commit that referenced this pull request Jan 13, 2020
PR-URL: #29053 Reviewed-By: Anna Henningsen <[email protected]>
targos pushed a commit that referenced this pull request Jan 13, 2020
PR-URL: #29053 Reviewed-By: Anna Henningsen <[email protected]>
BethGriggs pushed a commit that referenced this pull request Feb 6, 2020
PR-URL: #29053 Reviewed-By: Anna Henningsen <[email protected]>
BethGriggs pushed a commit that referenced this pull request Feb 6, 2020
PR-URL: #29053 Reviewed-By: Anna Henningsen <[email protected]>
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements cork/uncork on
OutgoingMessageto make it more streamlike.Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes