http: simplify drain#29081
Closed
http: simplify drain #29081
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
nodejs-github-bot added the lib / src 
Contributor
mscdex commented Aug 11, 2019
I think we should be using a symbol instead of an underscore-prefixed property. |
ronagforce-pushed the http-simplify-drain branch from 078268c to 054d050Compare
MemberAuthor
ronag commented Aug 11, 2019
@mscdex: fixed |
ronagforce-pushed the http-simplify-drain branch 7 times, most recently from e82d80e to a6486deCompare
mscdex reviewed Aug 11, 2019
Uh oh!
There was an error while loading. Please reload this page.
ronagforce-pushed the http-simplify-drain branch 4 times, most recently from e9184d5 to 35ba9c3Comparemscdex reviewed Aug 11, 2019
Uh oh!
There was an error while loading. Please reload this page.
ronagforce-pushed the http-simplify-drain branch 3 times, most recently from 2a6fb63 to 41a0458Compare
Member
Trott commented Aug 13, 2019
@nodejs/http |
Member
Trott commented Aug 16, 2019
@ronag Can you give this a rebase to get rid of the conflicts? @nodejs/collaborators @nodejs/streams This could use some reviews. |
ronagforce-pushed the http-simplify-drain branch from 41a0458 to dcca00fCompareMemberAuthor
ronag commented Aug 17, 2019
@Trott fixed |
ronagforce-pushed the http-simplify-drain branch from dcca00f to 73e760fCompare
mcollina approved these changes Aug 19, 2019
Uh oh!
There was an error while loading. Please reload this page.
Collaborator
nodejs-github-bot commented Aug 19, 2019
Collaborator
nodejs-github-bot commented Aug 19, 2019
Member
Trott commented Aug 19, 2019
Landed in bdf07f4 |
Trott pushed a commit that referenced this pull request Aug 19, 2019
Simplify and slightly optimize draining outgoing http streams. Avoid extra event listener and inline with rest of the drain logic. PR-URL: #29081 Reviewed-By: Matteo Collina <[email protected]>
targos pushed a commit that referenced this pull request Aug 20, 2019
Simplify and slightly optimize draining outgoing http streams. Avoid extra event listener and inline with rest of the drain logic. PR-URL: #29081 Reviewed-By: Matteo Collina <[email protected]>
This was referenced Aug 20, 2019
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Simplify and slightly optimize draining outgoing http streams.
Avoid extra event listener and inline with rest of the drain logic.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesNOTE TO SELF: After this is merged add
destroyedand ensure'drain'is not emitted afterdestroy(). Also look into removing unnecessary flush class in write.