readline: support closing dumb terminals#29149
Merged
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
nodejs-github-bot added the readline 
bnoordhuis approved these changes Aug 15, 2019
Member
bnoordhuis left a comment
bnoordhuis left a comment There was a problem hiding this comment.
Would be nice to test ^C as well but LGTM either way.
jasnell approved these changes Aug 16, 2019
lpinca approved these changes Aug 16, 2019
Collaborator
nodejs-github-bot commented Aug 17, 2019
Collaborator
CI: https://ci.nodejs.org/job/node-test-pull-request/25054/ EDIT: CI was green. |
cjihrig added the author ready 
This commit adds support for closing a readline interface on Control+C when the terminal is dumb. PR-URL: nodejs#29149Fixes: nodejs#29111 Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
This commit adds support for closing a readline interface on Control+D when the terminal is dumb. PR-URL: nodejs#29149Fixes: nodejs#29111 Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
targos pushed a commit that referenced this pull request Aug 19, 2019
This commit adds support for closing a readline interface on Control+C when the terminal is dumb. PR-URL: #29149Fixes: #29111 Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
targos pushed a commit that referenced this pull request Aug 19, 2019
This commit adds support for closing a readline interface on Control+D when the terminal is dumb. PR-URL: #29149Fixes: #29111 Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
This was referenced Aug 20, 2019
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #29111
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes